Skip to content

Conversation

@ArendJan
Copy link
Contributor

@ArendJan ArendJan commented Nov 5, 2025

Minimization things:

  • don't install all compilers and libaries for platformio devices
  • Dont install compiler for pico code
  • remove node_modules for web-frontend as rebuilding of never done and often too heavy for orange pi zero2

Other changes:

  • Adds INSTALL_ARDUINO_ALL setting (env var) that enables pico compiler or just downloads pre-built uf2
  • adds MIRTE_SRC_DIR env var that's set to /usr/local/src/mirte/ by default, but can be overwritten when wanted
  • removed some fix scripts for other things that shouldn't be in here
  • add web install check

@ArendJan ArendJan requested a review from Copilot November 5, 2025 16:19
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR minimizes the SD image size by making compiler and library installations optional for Arduino/PlatformIO devices, removing unnecessary node_modules after building the web frontend, and introducing environment variables for configuration flexibility.

Key Changes:

  • Introduces INSTALL_ARDUINO_ALL environment variable to control whether to build from source or use pre-built binaries for Pico devices
  • Adds MIRTE_SRC_DIR environment variable with default value /usr/local/src/mirte that can be overridden
  • Removes obsolete fix scripts and adds web installation testing to CI

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
usb_ethernet.sh Updates MIRTE_SRC_DIR to use environment variable with fallback
run_arduino.sh Adds INSTALL_ARDUINO_ALL support and conditional Pico building
network_setup.sh Updates MIRTE_SRC_DIR to use environment variable with fallback
network_install.sh Updates MIRTE_SRC_DIR to use environment variable with fallback
install_web.sh Removes node_modules after build, moves deactivate_node call, adds --single-branch to git clone
install_vscode.sh Updates MIRTE_SRC_DIR to use environment variable with fallback
install_mirte_master.sh Updates MIRTE_SRC_DIR to use environment variable with fallback
install_mirte.sh Updates MIRTE_SRC_DIR to use environment variable with fallback
install_jupyter_ros.sh Updates MIRTE_SRC_DIR to use environment variable with fallback
install_arduino.sh Implements conditional installation based on INSTALL_ARDUINO_ALL, downloads pre-built binaries when false
install_ROS2.sh Updates MIRTE_SRC_DIR and adds --single-branch to git clone
install_ROS.sh Updates MIRTE_SRC_DIR to use environment variable with fallback
fix_scripts/fix-wifi-connect.sh Removes obsolete WiFi connection fix script
fix_scripts/fix-networking.sh Removes obsolete networking fix script
create_user.sh Updates MIRTE_SRC_DIR to use environment variable with fallback
.github/workflows/test_install.yml Adds matrix testing for INSTALL_ARDUINO_ALL and new web-install job

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ArendJan and others added 3 commits November 5, 2025 17:24
Copy link
Contributor

@mklomp mklomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ArendJan ArendJan merged commit bcfe766 into mirte-robot:develop Nov 7, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants