-
Notifications
You must be signed in to change notification settings - Fork 4
Minimize sd image #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR minimizes the SD image size by making compiler and library installations optional for Arduino/PlatformIO devices, removing unnecessary node_modules after building the web frontend, and introducing environment variables for configuration flexibility.
Key Changes:
- Introduces
INSTALL_ARDUINO_ALLenvironment variable to control whether to build from source or use pre-built binaries for Pico devices - Adds
MIRTE_SRC_DIRenvironment variable with default value/usr/local/src/mirtethat can be overridden - Removes obsolete fix scripts and adds web installation testing to CI
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| usb_ethernet.sh | Updates MIRTE_SRC_DIR to use environment variable with fallback |
| run_arduino.sh | Adds INSTALL_ARDUINO_ALL support and conditional Pico building |
| network_setup.sh | Updates MIRTE_SRC_DIR to use environment variable with fallback |
| network_install.sh | Updates MIRTE_SRC_DIR to use environment variable with fallback |
| install_web.sh | Removes node_modules after build, moves deactivate_node call, adds --single-branch to git clone |
| install_vscode.sh | Updates MIRTE_SRC_DIR to use environment variable with fallback |
| install_mirte_master.sh | Updates MIRTE_SRC_DIR to use environment variable with fallback |
| install_mirte.sh | Updates MIRTE_SRC_DIR to use environment variable with fallback |
| install_jupyter_ros.sh | Updates MIRTE_SRC_DIR to use environment variable with fallback |
| install_arduino.sh | Implements conditional installation based on INSTALL_ARDUINO_ALL, downloads pre-built binaries when false |
| install_ROS2.sh | Updates MIRTE_SRC_DIR and adds --single-branch to git clone |
| install_ROS.sh | Updates MIRTE_SRC_DIR to use environment variable with fallback |
| fix_scripts/fix-wifi-connect.sh | Removes obsolete WiFi connection fix script |
| fix_scripts/fix-networking.sh | Removes obsolete networking fix script |
| create_user.sh | Updates MIRTE_SRC_DIR to use environment variable with fallback |
| .github/workflows/test_install.yml | Adds matrix testing for INSTALL_ARDUINO_ALL and new web-install job |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
mklomp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Minimization things:
Other changes: