Skip to content

Add ARM builds#377

Draft
JoeyBG wants to merge 1 commit intomasterfrom
feature/multi-arch
Draft

Add ARM builds#377
JoeyBG wants to merge 1 commit intomasterfrom
feature/multi-arch

Conversation

@JoeyBG
Copy link
Copy Markdown
Contributor

@JoeyBG JoeyBG commented Sep 22, 2023

Blocked by tonistiigi/binfmt#120.

@AAS97
Copy link
Copy Markdown

AAS97 commented Dec 21, 2023

Hello @JoeyBG , I see that blocking PR has been merged. Could we move forward on merging this PR?

@JoeyBG
Copy link
Copy Markdown
Contributor Author

JoeyBG commented Dec 21, 2023

Hi @AAS97,

As you can see, the ARM build still fails with the new version, there is a dependancy that does not quite work when building with QEMU. I did not have time to investigate what was causing the issue, if you have any time to dig into it I would appreciate it! I'm not sure when I'll be able to get back to this.

@AAS97
Copy link
Copy Markdown

AAS97 commented Dec 22, 2023

I'm on a Mac M1.

  • Docker build errors on the feature/multi-arch
  • Docker build passes on the latest tag of main (v1.19.9)

Maybe I'm missing something, but it seems that the error could be solved by merging main incorporating the deps updates that were released since v1.19.4.

@rwojsznis
Copy link
Copy Markdown

Seems like this technically could be merged already? 🤔

(also closes #486)

baarde added a commit to baarde/accent that referenced this pull request Feb 10, 2026
The JMSingle flag is needed to disable dual mapping, which doesn't work with QEMU user mode emulation.

This should unblock mirego#377.
@simonprev
Copy link
Copy Markdown
Member

@JoeyBG If you have time to try with this fix #493

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants