Open
Conversation
Collaborator
Closed
Contributor
|
Hi @campeasb, Thanks for your work on this. However @magdalenafuentes, @genisplaja, I believe this PR should be blocked until #625 is reviewed and merged. That pull request represents the original implementation of FMAK, and it includes contributions from both myself and my collaborator Gandalf Hernandez @gandalfhz Once PR #625 is merged, we welcome your updates, which can be made by building on top of #625 to preserve the contribution history and maintain proper attribution. Looking forward to collaborating constructively moving forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First PR for fmakv2 dataset contribution.
I am very new to coding and contributing, so I will probably need extra explanation when correcting all of this.
Some parts of the code come from Stella's work, I changed the metadata to match Yuexuan's one on Zenodo (download link).
About the tests :