Fix SetBucketLifecycle() to send properly formed XML#2213
Open
isimluk wants to merge 2 commits intominio:masterfrom
Open
Fix SetBucketLifecycle() to send properly formed XML#2213isimluk wants to merge 2 commits intominio:masterfrom
isimluk wants to merge 2 commits intominio:masterfrom
Conversation
Contributor
isimluk
force-pushed
the
fix-put-lifecycle
branch
from
383366b to
bba1faa
Compare
https://docs.aws.amazon.com/AmazonS3/latest/API/API_LifecycleRule.html mentions that Filter is required if the LifecycleRule does not contain a Prefix element. After minio#2177, this requirement is broken for bucket-global (=prefixless) rules. And clients setting such may run into server side validation issues like. HTTP/1.1 400 Bad Request <?xml version="1.0" encoding="UTF-8"?> <Error> <Code>MalformedXML</Code> ... </Error>
isimluk
force-pushed
the
fix-put-lifecycle
branch
from
bba1faa to
55ca5dc
Compare
Author
|
Fixed gofumpt (hopefully). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://docs.aws.amazon.com/AmazonS3/latest/API/API_LifecycleRule.html mentions that
Filter is required if the LifecycleRule does not contain a Prefix element.
After #2177, this requirement is broken for bucket-global (=prefixless) rules. And clients setting such may run into server side validation issues like.
HTTP/1.1 400 Bad Request