Skip to content

Comments

Add missing AWS regions and sort them alphabetically.#1174

Open
notanaverageman wants to merge 1 commit intominio:masterfrom
notanaverageman:patch-1
Open

Add missing AWS regions and sort them alphabetically.#1174
notanaverageman wants to merge 1 commit intominio:masterfrom
notanaverageman:patch-1

Conversation

@notanaverageman
Copy link

@notanaverageman
Copy link
Author

@ebozduman can you review this PR? It is a simple one that only adds missing endpoints. We can't use the library on missing regions.

@ebozduman
Copy link
Collaborator

ebozduman commented Sep 13, 2024

@notanaverageman

Your change looks good. However, all the build checks are expected to pass for the PR to be merged.
The functional test issue you see for this PR is due to a known issue, #1118 and we are working on it.
As soon as #1118 is resolved, we'll merge this PR.

@ebozduman
Copy link
Collaborator

@notanaverageman
We'd appreciate it if you could resolve the conflicts.
The work needs to be done on the branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants