fix: await background load futures during cancellation and fix loadingTimeoutMs default#48855
fix: await background load futures during cancellation and fix loadingTimeoutMs default#48855sparknack wants to merge 3 commits intomilvus-io:masterfrom
Conversation
…nslators Ensure background load futures are properly awaited during cancellation cleanup in both GroupChunkTranslator and ManifestGroupTranslator to prevent dangling async operations. Also add CheckCancellation calls in LoadCellBatchAsync to support early termination during cell loading. Signed-off-by: Shawn Wang <shawn.wang@zilliz.com>
Signed-off-by: Shawn Wang <shawn.wang@zilliz.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sparknack The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
[ci-v2-notice] To rerun ci-v2 checks, comment with:
If you have any questions or requests, please contact @zhikunyao. |
Codecov Report❌ Patch coverage is Please upload reports for the commit 339021d to get more accurate results. ❌ Your patch check has failed because the patch coverage (67.50%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #48855 +/- ##
==========================================
- Coverage 84.29% 83.49% -0.81%
==========================================
Files 633 645 +12
Lines 99080 101186 +2106
==========================================
+ Hits 83516 84481 +965
- Misses 15564 16653 +1089
- Partials 0 52 +52
🚀 New features to boost your workflow:
|
Signed-off-by: Shawn Wang <shawn.wang@zilliz.com>
Summary
GroupChunkTranslatorandManifestGroupTranslatorcancellation cleanup paths to prevent use-after-free / dangling futuresCheckCancellationcalls inLoadCellBatchAsyncloop for prompt cancellationtieredStorage.loadingTimeoutMsdefault from0(immediate failure) to-1(no timeout)issue: #48854
Test plan
CancellationStopsMidBatchPushverifying mid-batch cancellation stops loading and raisesFollyCancel