Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2634,6 +2634,7 @@ public R<RpcStatus> dropRole(DropRoleParam requestParam) {
try {
DropRoleRequest request = DropRoleRequest.newBuilder()
.setRoleName(requestParam.getRoleName())
.setForceDrop(requestParam.isForceDrop())
.build();

Status response = blockingStub().dropRole(request);
Expand Down
19 changes: 19 additions & 0 deletions sdk-core/src/main/java/io/milvus/param/role/DropRoleParam.java
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,14 @@
public class DropRoleParam {

private final String roleName;
private final boolean forceDrop;

private DropRoleParam(DropRoleParam.Builder builder) {
if (builder == null) {
throw new IllegalArgumentException("Builder cannot be null");
}
this.roleName = builder.roleName;
this.forceDrop = builder.forceDrop;
}

public static DropRoleParam.Builder newBuilder() {
Expand All @@ -41,10 +43,15 @@ public String getRoleName() {
return roleName;
}

public boolean isForceDrop() {
return forceDrop;
}

@Override
public String toString() {
return "DropRoleParam{" +
"roleName='" + roleName + '\'' +
", forceDrop=" + forceDrop +
'}';
}

Expand All @@ -53,6 +60,7 @@ public String toString() {
*/
public static final class Builder {
private String roleName;
private boolean forceDrop;

private Builder() {
}
Expand All @@ -71,6 +79,17 @@ public DropRoleParam.Builder withRoleName(String roleName) {
return this;
}

/**
* Sets the forceDrop flag. If true, the role will be force dropped.
*
* @param forceDrop forceDrop
* @return <code>Builder</code>
*/
public DropRoleParam.Builder withForceDrop(boolean forceDrop) {
this.forceDrop = forceDrop;
return this;
}

/**
* Verifies parameters and creates a new {@link DropRoleParam} instance.
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ public class CDCService extends BaseService {
public UpdateReplicateConfigurationResp updateReplicateConfiguration(MilvusServiceGrpc.MilvusServiceBlockingStub blockingStub, UpdateReplicateConfigurationReq requestParam) {
UpdateReplicateConfigurationRequest request = UpdateReplicateConfigurationRequest.newBuilder()
.setReplicateConfiguration(requestParam.getReplicateConfiguration().toGRPC())
.setForcePromote(requestParam.isForcePromote())
.build();

String title = "UpdateReplicateConfiguration";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,15 @@

public class UpdateReplicateConfigurationReq {
private ReplicateConfiguration replicateConfiguration;
private boolean forcePromote;

public static UpdateReplicateConfigurationReqBuilder builder() {
return new UpdateReplicateConfigurationReqBuilder();
}

private UpdateReplicateConfigurationReq(UpdateReplicateConfigurationReqBuilder builder) {
this.replicateConfiguration = builder.replicateConfiguration;
this.forcePromote = builder.forcePromote;
}

public ReplicateConfiguration getReplicateConfiguration() {
Expand All @@ -38,21 +40,36 @@ public void setReplicateConfiguration(ReplicateConfiguration replicateConfigurat
this.replicateConfiguration = replicateConfiguration;
}

public boolean isForcePromote() {
return forcePromote;
}

public void setForcePromote(boolean forcePromote) {
this.forcePromote = forcePromote;
}

@Override
public String toString() {
return "UpdateReplicateConfigurationReq{" +
"replicateConfiguration=" + replicateConfiguration +
", forcePromote=" + forcePromote +
'}';
}

public static class UpdateReplicateConfigurationReqBuilder {
private ReplicateConfiguration replicateConfiguration;
private boolean forcePromote;

public UpdateReplicateConfigurationReqBuilder replicateConfiguration(ReplicateConfiguration replicateConfiguration) {
this.replicateConfiguration = replicateConfiguration;
return this;
}

public UpdateReplicateConfigurationReqBuilder forcePromote(boolean forcePromote) {
this.forcePromote = forcePromote;
return this;
}

public UpdateReplicateConfigurationReq build() {
return new UpdateReplicateConfigurationReq(this);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ public Void dropRole(MilvusServiceGrpc.MilvusServiceBlockingStub blockingStub, D
String title = String.format("Drop role: '%s'", request.getRoleName());
DropRoleRequest dropRoleRequest = DropRoleRequest.newBuilder()
.setRoleName(request.getRoleName())
.setForceDrop(request.isForceDrop())
.build();
Status status = blockingStub.dropRole(dropRoleRequest);
rpcUtils.handleResponse(title, status);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,11 @@

public class DropRoleReq {
private String roleName;
private boolean forceDrop;

private DropRoleReq(DropRoleReqBuilder builder) {
this.roleName = builder.roleName;
this.forceDrop = builder.forceDrop;
}

public String getRoleName() {
Expand All @@ -34,10 +36,19 @@ public void setRoleName(String roleName) {
this.roleName = roleName;
}

public boolean isForceDrop() {
return forceDrop;
}

public void setForceDrop(boolean forceDrop) {
this.forceDrop = forceDrop;
}

@Override
public String toString() {
return "DropRoleReq{" +
"roleName='" + roleName + '\'' +
", forceDrop=" + forceDrop +
'}';
}

Expand All @@ -47,6 +58,7 @@ public static DropRoleReqBuilder builder() {

public static class DropRoleReqBuilder {
private String roleName;
private boolean forceDrop;

private DropRoleReqBuilder() {
}
Expand All @@ -56,6 +68,11 @@ public DropRoleReqBuilder roleName(String roleName) {
return this;
}

public DropRoleReqBuilder forceDrop(boolean forceDrop) {
this.forceDrop = forceDrop;
return this;
}

public DropRoleReq build() {
return new DropRoleReq(this);
}
Expand Down
Loading