Merged
Conversation
`traversals()` used `set.pop()` to pick the BFS/DFS start node, which could land on an interior node of an open path. This caused the traversal to backtrack or expand outward, producing non-edge consecutive pairs that `_split_traversal` would split on — fragmenting a single connected path into multiple pieces. Fix: compute node degrees and prefer degree-1 nodes (endpoints) as start points. For open paths this guarantees an end-to-end traversal with no backtracking. Closed paths (all degree-2) fall back to the original `set.pop()` behavior. Co-Authored-By: Claude Opus 4.6 <[email protected]>
## Summary `traversals()` uses `set.pop()` to pick the DFS/BFS start node. When this lands on an interior node of an open path, the traversal backtracks, producing non-edge consecutive pairs that `_split_traversal` splits on — fragmenting a single connected path into multiple entities. **Fix:** Compute node degrees and prefer degree-1 nodes (endpoints) as start points. For open paths this guarantees end-to-end traversal with no backtracking. Closed paths (all degree-2) fall back to the original behavior. ## Test plan - `test_traversal_no_fragmentation` — open chain → 1 traversal; two disjoint chains → 2 - `test_section_entity_count` — box and cylinder sections → 1 entity each - All existing `test_graph.py` and `test_section.py` tests pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
whileloop to boundedforloop in the traversals logic