Skip to content

Modify emissive factor validation range #2500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikedh merged 1 commit into from
Feb 10, 2026
+2 −2
Merged

Modify emissive factor validation range #2500

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions trimesh/visual/material.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,8 +381,8 @@ def emissiveFactor(self, value):
else:
# non-None values must be a floating point
emissive = np.array(value, dtype=np.float64).reshape(3)
if emissive.min() < -_eps or emissive.max() > (1 + _eps):
raise ValueError("all factors must be between 0.0-1.0")
if emissive.min() < -_eps :
raise ValueError("all factors must be greater than 0.0")
self._data["emissiveFactor"] = emissive

@property
Expand Down
Loading