Skip to content

feat: add storeOnDisk support for vfkit runner #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
astro merged 1 commit into from
Mar 30, 2026
+4 −3
Merged

feat: add storeOnDisk support for vfkit runner #495

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions lib/runners/vfkit.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ let

inherit (microvmConfig)
vcpu mem user interfaces shares socket
storeOnDisk kernel initrdPath kernelParams
storeOnDisk storeDisk kernel initrdPath kernelParams
balloon devices credentialFiles vsock graphics;

inherit (microvmConfig.vfkit) extraArgs logLevel rosetta;
Expand Down Expand Up @@ -43,6 +43,9 @@ let
] else [
"--device" "virtio-serial,stdio"
])
++ lib.optionals storeOnDisk [
"--device" "virtio-blk,path=${storeDisk},readonly"
]
++ (builtins.concatMap ({ image, ... }: [
"--device" "virtio-blk,path=${image}"
]) volumesWithLetters)
Expand Down Expand Up @@ -113,8 +116,6 @@ in
then throw "vfkit does not support credentialFiles"
else if vsock.cid != null
then throw "vfkit vsock support not yet implemented in microvm.nix"
else if storeOnDisk
then throw "vfkit does not support storeOnDisk. Use virtiofs shares instead (already configured in examples)."
else
let
baseCmd = lib.escapeShellArgs allArgsWithoutSocket;
Expand Down
Loading