-
Notifications
You must be signed in to change notification settings - Fork 9
Replace Windows Server 2019 with matrix strategy for Windows 2022 and 2025 in CI pipeline #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@mtfriesen 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
Co-authored-by: mtfriesen <[email protected]>
|
@copilot fix the build errors and use a matrix for the different windows images (2022 and 2025) instead of two separate jobs |
|
@copilot use windows-2022 instead of windows-latest, too |
Co-authored-by: mtfriesen <[email protected]>
I've consolidated the two separate Windows jobs into a single job using a matrix strategy for both Windows Server 2022 and 2025. This eliminates code duplication while maintaining all existing build configurations (Debug/Release, x86/x64/ARM64). The matrix approach provides better coverage and is more maintainable. Commit: 4fb205e |
The workflow is already using |
|
@copilot rebase |
The GitHub Actions workflow was referencing the retired
windows-2019runner, which has been deprecated by GitHub. Additionally, the workflow had duplicate jobs with identical steps running on different Windows versions.Changes made:
windows-2019runner referenceBuild-2025andBuild) into a single jobwindows-2022andwindows-2025The CI pipeline now uses a cleaner matrix approach that provides better Windows version coverage while being more maintainable and reducing redundancy.
Fixes #51.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.