-
Notifications
You must be signed in to change notification settings - Fork 334
[http-specs] Fix bulletPointsModel API signature to match runtime behavior #9200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed response type from NoContentResponse to OkResponse - Updated request body to wrap model in 'input' property - Updated scenarioDoc to reflect correct input format Co-authored-by: msyyc <[email protected]>
Copilot
AI
changed the title
[WIP] Fix API to follow expected runtime behavior
Fix bulletPointsModel API signature to match runtime behavior
Dec 12, 2025
msyyc
reviewed
Dec 12, 2025
9 tasks
Co-authored-by: msyyc <[email protected]>
commit: |
Contributor
|
All changed packages have been documented.
Show changes
|
msyyc
approved these changes
Dec 15, 2025
Contributor
|
@markcowl / @timotheeguerin Pls help review, thanks! |
tadelesh
approved these changes
Dec 18, 2025
timotheeguerin
approved these changes
Jan 7, 2026
Closed
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 19, 2026
…ded (#9387) Adds test coverage for the documentation namespace spec (bullet points, numbered lists, text formatting) to azure and unbranded mock API test suites, mirroring the existing generic_mock_api_tests. ## Changes - **New test files**: - `test_specs_documentation.py` in azure/mock_api_tests and unbranded/mock_api_tests - `test_specs_documentation_async.py` in azure/mock_api_tests/asynctests and unbranded/mock_api_tests/asynctests - **Test coverage**: All 6 scenarios from TypeSpec documentation spec: - Lists: bulletPointsOp, bulletPointsModel (skipped per #9173), numbered - Text formatting: boldText, italicText, combinedFormatting - **Changelog**: Added entry under version 0.24.2 Tests follow the same pattern as other azure/unbranded tests (e.g., encode_duration). <!-- START COPILOT ORIGINAL PROMPT --> <details> <summary>Original prompt</summary> > > ---- > > *This section details on the original issue you should resolve* > > <issue_title>[python] add test case</issue_title> > <issue_description>GOAL: > - add test case in /workspaces/typespec/packages/http-client-python/generator/test/generic_mock_api_tests/test_specs_documentation.py and /workspaces/typespec/packages/http-client-python/generator/test/generic_mock_api_tests/asynctests/test_specs_documentation_async.py for #9200 which fixed a case then we could test it. > - add test case in /workspaces/typespec/packages/http-client-python/generator/test/azure/mock_api_tests and /workspaces/typespec/packages/http-client-python/generator/test/unbranded/mock_api_tests for https://github.com/microsoft/typespec/pull/9259/files which added a new case > > NOTE: > - DO add changelog > - DO format your changed files before commit</issue_description> > > ## Comments on the Issue (you are @copilot in this section) > > <comments> > </comments> > </details> <!-- START COPILOT CODING AGENT SUFFIX --> - Fixes #9386 <!-- START COPILOT CODING AGENT TIPS --> --- ✨ Let Copilot coding agent [set things up for you](https://github.com/microsoft/typespec/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --------- Co-authored-by: Yuchao Yan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plan to fix bulletPointsModel API and runtime behavior mismatch
op bulletPointsModelresponse type fromNoContentResponsetoOkResponseinputproperty to match the expected format{ "input": {"prop": "Simple"} }pnpm ciin http-specs folder - formatting and validation passedChanges Made:
main.tsp
NoContentResponse(status 204) toOkResponse(status 200){"input": {"prop": "Simple"}}mockapi.ts
inputproperty to match the operation signature{input: {prop: "Simple"}}instead of{prop: "Simple"}Changelog
.chronus/changes/documenting the fixAll changes compile successfully and validation passed (717 scenarios passed, 2 pre-existing failures unrelated to this change).
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.