fix bounding box calculations for the accelerometer tilt effect#6828
Merged
Conversation
srietkerk
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #6103
this fixes the accelerometer tilt effect.
previously, all calculations for determining the mouse position within the board were based on
getBoundingClientRect(). the problem with that approach is that the CSS transformation we apply to make the micro:bit look like it's tilting changes the bounds returned by that function (getBoundingClientRect()is calculated post CSS). as a result, we get some weird results for certain screen sizes and aspect ratios where the board moves itself out from underneath the mouse pointer when it tilts.to fix this, this PR makes two changes:
together, these two changes give us a constant bounding box instead of a moving target.
while i was here, i also switched the tilt decay function to use
requestAnimationFrameinstead ofsetInterval, so the decay is now much smoother than before (and a little quicker, but I think it looks nice).