Skip to content

feat(html-reporter): show indirect attachment indicator on parent steps#40087

Merged
pavelfeldman merged 2 commits intomicrosoft:mainfrom
pavelfeldman:feat-40078
Apr 7, 2026
Merged

feat(html-reporter): show indirect attachment indicator on parent steps#40087
pavelfeldman merged 2 commits intomicrosoft:mainfrom
pavelfeldman:feat-40078

Conversation

@pavelfeldman
Copy link
Copy Markdown
Member

Summary

  • Add a small greyed-out, non-interactive marker on a step row when one of its descendants has an attachment but the step itself does not.
  • Helps spot attachments inside collapsed test.step()/playwright-bdd trees without expanding every level.

Closes #40078

When a parent step has no direct attachment but a descendant does, render
a small greyed-out, non-interactive marker on the parent row so collapsed
trees still surface that an attachment exists somewhere inside.

Closes: microsoft#40078
Copy link
Copy Markdown
Member

@yury-s yury-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a screenshot?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

Test results for "MCP"

1 failed
❌ [chrome] › mcp/dashboard.spec.ts:48 › should show current workspace sessions first @mcp-windows-latest

6441 passed, 383 skipped


Merge workflow run.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

Test results for "tests 1"

6 flaky ⚠️ [chromium-library] › library/video.spec.ts:342 › screencast › should work for popups `@ubuntu-22.04-chromium-tip-of-tree`
⚠️ [chromium-library] › library/video.spec.ts:342 › screencast › should work for popups `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-page] › page/page-request-continue.spec.ts:754 › propagate headers cross origin redirect after interception `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/video.spec.ts:342 › screencast › should work for popups `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/video.spec.ts:481 › screencast › should capture static page in persistent context @smoke `@chromium-ubuntu-22.04-node24`
⚠️ [firefox-page] › page/page-request-gc.spec.ts:19 › should work `@firefox-ubuntu-22.04-node20`

39151 passed, 846 skipped


Merge workflow run.

@pavelfeldman pavelfeldman merged commit 5a56d44 into microsoft:main Apr 7, 2026
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Attachment indicator for parent steps

2 participants