chore(cli): self-documenting cli.config.json#40081
chore(cli): self-documenting cli.config.json#40081Skn0tt wants to merge 7 commits intomicrosoft:mainfrom
cli.config.json#40081Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
|
||
| import type * as playwright from '../../..'; | ||
|
|
||
| // This file contains type declarations for the MCP and CLI config. Please keep the following files in sync: |
There was a problem hiding this comment.
I think this file is copied verbatim to microsoft/playwright-mcp repo, so let's not have internal comments inside.
There was a problem hiding this comment.
I think we need the comment so that agents know to keep the other one updated. Why are you concerned about adding it to the other repo?
| // Chrome DevTools Protocol endpoint to connect to an existing browser instance. | ||
| // "cdpEndpoint": "http://localhost:9222", | ||
|
|
||
| // Timeout in milliseconds for connecting to CDP endpoint. Defaults to 30000. |
There was a problem hiding this comment.
Let's drop unnecessary fields like cdpTimeout from here?
There was a problem hiding this comment.
i dropped cdpTimeout and added disclaimers to others, that they're only about MCP and not CLI
There was a problem hiding this comment.
scratch that, I dropped the others. let's start with CLI only, it'd be confusing to have MCP configs in there.
| }, | ||
|
|
||
| // List of enabled tool capabilities. | ||
| // Possible values: "config", "core", "core-navigation", "core-tabs", |
There was a problem hiding this comment.
It's hard to imagine this list of possible values will be kept in sync.
There was a problem hiding this comment.
while we have the comment, I'd hope the agent keeps it in sync 🤷
Test results for "tests 1"1 failed 8 flaky39138 passed, 846 skipped Merge workflow run. |
Test results for "MCP"206 failed @mcp-windows-latest❌ [msedge] › mcp/cli-keyboard.spec.ts:19 › press @mcp-windows-latest❌ [msedge] › mcp/cli-keyboard.spec.ts:28 › keydown keyup @mcp-windows-latest❌ [msedge] › mcp/cli-misc.spec.ts:21 › daemon shuts down on browser launch failure @mcp-windows-latest❌ [msedge] › mcp/cli-misc.spec.ts:63 › install creates default config @mcp-windows-latest❌ [msedge] › mcp/cli-mouse.spec.ts:19 › mousemove @mcp-windows-latest❌ [msedge] › mcp/cli-mouse.spec.ts:27 › mousedown mouseup @mcp-windows-latest❌ [msedge] › mcp/cli-mouse.spec.ts:38 › mousewheel @mcp-windows-latest❌ [msedge] › mcp/cli-navigation.spec.ts:19 › go-back @mcp-windows-latest❌ [msedge] › mcp/cli-navigation.spec.ts:28 › go-forward @mcp-windows-latest❌ [msedge] › mcp/cli-navigation.spec.ts:38 › open without url opens about:blank @mcp-windows-latest❌ [msedge] › mcp/cli-navigation.spec.ts:43 › tab-new with url @mcp-windows-latest❌ [msedge] › mcp/cli-navigation.spec.ts:50 › run-code @mcp-windows-latest❌ [msedge] › mcp/cli-network-offline.spec.ts:19 › network-state-set toggles offline state @mcp-windows-latest❌ [msedge] › mcp/cli-parsing.spec.ts:31 › too many arguments @mcp-windows-latest❌ [msedge] › mcp/cli-parsing.spec.ts:37 › wrong option type @mcp-windows-latest❌ [msedge] › mcp/cli-parsing.spec.ts:47 › arg after boolean option @mcp-windows-latest❌ [msedge] › mcp/cli-parsing.spec.ts:53 › missing argument @mcp-windows-latest❌ [msedge] › mcp/cli-parsing.spec.ts:60 › wrong argument type @mcp-windows-latest❌ [msedge] › mcp/cli-parsing.spec.ts:69 › should preserve leading zeros in string arguments @mcp-windows-latest❌ [msedge] › mcp/cli-persistent.spec.ts:20 › should use userDataDir from config without --persistent flag @mcp-windows-latest❌ [msedge] › mcp/cli-route.spec.ts:19 › route-list shows no routes when empty @mcp-windows-latest❌ [msedge] › mcp/cli-route.spec.ts:25 › route adds a mock and route-list shows it @mcp-windows-latest❌ [msedge] › mcp/cli-route.spec.ts:38 › route with content-type @mcp-windows-latest❌ [msedge] › mcp/cli-route.spec.ts:48 › route with header @mcp-windows-latest❌ [msedge] › mcp/cli-route.spec.ts:58 › route with numerical body @mcp-windows-latest❌ [msedge] › mcp/cli-route.spec.ts:68 › unroute removes specific route @mcp-windows-latest❌ [msedge] › mcp/cli-route.spec.ts:85 › unroute removes all routes @mcp-windows-latest❌ [msedge] › mcp/cli-run-code.spec.ts:21 › run-code inline @mcp-windows-latest❌ [msedge] › mcp/cli-run-code.spec.ts:30 › run-code from file @mcp-windows-latest❌ [msedge] › mcp/cli-run-code.spec.ts:43 › run-code from file with template literals @mcp-windows-latest❌ [msedge] › mcp/cli-save-as.spec.ts:19 › screenshot @mcp-windows-latest❌ [msedge] › mcp/cli-save-as.spec.ts:26 › screenshot @mcp-windows-latest❌ [msedge] › mcp/cli-save-as.spec.ts:34 › screenshot --full-page @mcp-windows-latest❌ [msedge] › mcp/cli-save-as.spec.ts:41 › screenshot --filename @mcp-windows-latest❌ [msedge] › mcp/cli-session.spec.ts:24 › list @mcp-windows-latest❌ [msedge] › mcp/cli-session.spec.ts:51 › close @mcp-windows-latest❌ [msedge] › mcp/cli-session.spec.ts:61 › close named session @mcp-windows-latest❌ [msedge] › mcp/cli-session.spec.ts:73 › persistent session shows in list after close @mcp-windows-latest❌ [msedge] › mcp/cli-session.spec.ts:86 › close-all @mcp-windows-latest❌ [msedge] › mcp/cli-session.spec.ts:100 › delete-data @mcp-windows-latest❌ [msedge] › mcp/cli-session.spec.ts:112 › delete-data named session @mcp-windows-latest❌ [msedge] › mcp/cli-session.spec.ts:129 › session stops when browser exits @mcp-windows-latest❌ [msedge] › mcp/cli-session.spec.ts:143 › session reopen with different config @mcp-windows-latest❌ [msedge] › mcp/cli-session.spec.ts:160 › workspace isolation - sessions in different workspaces are isolated @mcp-windows-latest❌ [msedge] › mcp/cli-session.spec.ts:192 › list --all lists sessions from all workspaces @mcp-windows-latest❌ [msedge] › mcp/cli-session.spec.ts:260 › newer client with older daemon is compatible @mcp-windows-latest❌ [msedge] › mcp/cli-session.spec.ts:267 › older client with newer daemon fails with version mismatch error @mcp-windows-latest❌ [msedge] › mcp/cli-session.spec.ts:278 › older client with newer daemon - named session includes session name in error @mcp-windows-latest❌ [msedge] › mcp/cli-session.spec.ts:289 › older client with newer daemon - list shows incompatible warning @mcp-windows-latest❌ [msedge] › mcp/cli-storage.spec.ts:21 › state-save saves storage state to file @mcp-windows-latest❌ [msedge] › mcp/cli-storage.spec.ts:48 › state-save saves to custom filename @mcp-windows-latest❌ [msedge] › mcp/cli-storage.spec.ts:61 › state-load restores storage state from file @mcp-windows-latest❌ [msedge] › mcp/cli-storage.spec.ts:100 › state-save and state-load roundtrip @mcp-windows-latest❌ [msedge] › mcp/cli-webstorage.spec.ts:20 › localstorage-list shows no items when empty @mcp-windows-latest❌ [msedge] › mcp/cli-webstorage.spec.ts:29 › localstorage-set and localstorage-get @mcp-windows-latest❌ [msedge] › mcp/cli-webstorage.spec.ts:43 › localstorage-list shows items @mcp-windows-latest❌ [msedge] › mcp/cli-webstorage.spec.ts:56 › localstorage-delete removes item @mcp-windows-latest❌ [msedge] › mcp/cli-webstorage.spec.ts:71 › localstorage-clear removes all items @mcp-windows-latest❌ [msedge] › mcp/cli-webstorage.spec.ts:87 › sessionstorage-list shows no items when empty @mcp-windows-latest❌ [msedge] › mcp/cli-webstorage.spec.ts:96 › sessionstorage-set and sessionstorage-get @mcp-windows-latest❌ [msedge] › mcp/cli-webstorage.spec.ts:110 › sessionstorage-list shows items @mcp-windows-latest❌ [msedge] › mcp/cli-webstorage.spec.ts:123 › sessionstorage-delete removes item @mcp-windows-latest❌ [msedge] › mcp/cli-webstorage.spec.ts:138 › sessionstorage-clear removes all items @mcp-windows-latest❌ [msedge] › mcp/config.ini.spec.ts:19 › ini config sets viewport @mcp-windows-latest❌ [msedge] › mcp/config.ini.spec.ts:39 › ini config sets timeouts and console level @mcp-windows-latest❌ [msedge] › mcp/config.ini.spec.ts:57 › ini config sets browser launch options @mcp-windows-latest❌ [msedge] › mcp/config.ini.spec.ts:72 › ini config sets context options @mcp-windows-latest❌ [msedge] › mcp/config.ini.spec.ts:89 › ini config sets server and network options @mcp-windows-latest❌ [msedge] › mcp/config.ini.spec.ts:104 › ini config boolean values @mcp-windows-latest❌ [msedge] › mcp/dashboard.spec.ts:26 › should show browser session chip @mcp-windows-latest❌ [msedge] › mcp/dashboard.spec.ts:34 › should show devtools sidebar @mcp-windows-latest❌ [msedge] › mcp/dashboard.spec.ts:48 › should show current workspace sessions first @mcp-windows-latest❌ [msedge] › mcp/dashboard.spec.ts:83 › should pick locator from browser @mcp-windows-latest❌ [firefox] › mcp/config.ini.spec.ts:19 › ini config sets viewport @mcp-macos-latest❌ [firefox] › mcp/config.ini.spec.ts:39 › ini config sets timeouts and console level @mcp-macos-latest❌ [firefox] › mcp/config.ini.spec.ts:57 › ini config sets browser launch options @mcp-macos-latest❌ [firefox] › mcp/config.ini.spec.ts:72 › ini config sets context options @mcp-macos-latest❌ [firefox] › mcp/config.ini.spec.ts:89 › ini config sets server and network options @mcp-macos-latest❌ [firefox] › mcp/config.ini.spec.ts:104 › ini config boolean values @mcp-macos-latest❌ [webkit] › mcp/config.ini.spec.ts:19 › ini config sets viewport @mcp-macos-latest❌ [webkit] › mcp/config.ini.spec.ts:39 › ini config sets timeouts and console level @mcp-macos-latest❌ [webkit] › mcp/config.ini.spec.ts:57 › ini config sets browser launch options @mcp-macos-latest❌ [webkit] › mcp/config.ini.spec.ts:72 › ini config sets context options @mcp-macos-latest❌ [webkit] › mcp/config.ini.spec.ts:89 › ini config sets server and network options @mcp-macos-latest❌ [webkit] › mcp/config.ini.spec.ts:104 › ini config boolean values @mcp-macos-latest
6249 passed, 383 skipped Merge workflow run. |
2 participants
jsoncis maintained by the VS Code folks and weighs ~8kb.