fix: remove dotnet from components to build#16457
Open
binujp wants to merge 1 commit intotomls/base/mainfrom
Open
fix: remove dotnet from components to build#16457binujp wants to merge 1 commit intotomls/base/mainfrom
binujp wants to merge 1 commit intotomls/base/mainfrom
Conversation
'dotnet9.0' fails to build due to version pinning. For azl4 we want partner teams to build and deliver dotnet. dotnet9.0 is not a buildrequires or runtime requires for any of the packages in the toml. We can get rid of it from the components to build list.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the dotnet9.0 component entry from the repository’s full components list so it is no longer included in the set of components built as part of the base build (aligning with the stated goal that partner teams build/deliver dotnet separately).
Changes:
- Removed the
[components.'dotnet9.0']entry fromcomponents-full.toml.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
'dotnet9.0' fails to build due to version pinning. For azl4 we want partner teams to build and deliver dotnet. dotnet9.0 is not a buildrequires or runtime requires for any of the packages in the toml. We can get rid of it from the components to build list.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
Change Log
Does this affect the toolchain?
YES/NO
Associated issues
Links to CVEs
Test Methodology