add weave tracer #277
add weave tracer #277
Conversation
|
Generally I don't think it's necessary to support non-OTLP path for advanced tracers. You can first check whether the store has OTLP capability within You can inject the rollout_id and attempt_id if you have control over |
tests/tracer/test_weave.py
Outdated
|
|
||
| async def add_span(self, span: Span) -> Span: | ||
| self.spans.append(span) | ||
| return span # 返回同类型 |
pyrightconfig.json
Outdated
| "exclude": [ | ||
| "**/data", | ||
| "**/assets", | ||
| "agentlightning/tracer/weave.py" |
There was a problem hiding this comment.
weave.py should not be excluded in pyrightconfig full.
revert the file.
agentlightning/tracer/weave.py
Outdated
| output = getattr(call, "output", {}) # type: ignore | ||
| attributes = sanitize(inputs, output) | ||
|
|
||
| def is_success(summary: dict) -> bool: |
There was a problem hiding this comment.
test this logic in unit-test
There was a problem hiding this comment.
removed, there was a bug here, change to read another var.
agentlightning/tracer/weave.py
Outdated
|
|
||
| if self._store and self._rollout_id and self._attempt_id: | ||
| try: | ||
| for span in spans: |
There was a problem hiding this comment.
there is an add_many_spans interface now.
| return self.spans | ||
|
|
||
|
|
||
| def _func_without_exception(): |
There was a problem hiding this comment.
The weave tests should at least cover a real @weave.op. Otherwise I'm not sure whether it will work.
agentlightning/tracer/weave.py
Outdated
| self._loop_thread: Optional[threading.Thread] = None | ||
|
|
||
| def instrument(self, worker_id: int): | ||
| instrument_all() |
There was a problem hiding this comment.
I think I'll sunset instrument_all soon. Don't use _all(), instrument_weave() instead.
| weave_client.finish_call(trace_call) # type: ignore | ||
| await self._on_finish_handler(trace_call) # type: ignore | ||
|
|
||
| def shutdown(self) -> None: |
There was a problem hiding this comment.
why do we need the shutdown here?
2 participants
No description provided.