Python: Add include_reference_source_data to agentic search requests#5100
Open
mvanhorn wants to merge 1 commit intomicrosoft:mainfrom
Open
Python: Add include_reference_source_data to agentic search requests#5100mvanhorn wants to merge 1 commit intomicrosoft:mainfrom
mvanhorn wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Pass knowledge_source_params with include_reference_source_data=True to both KnowledgeBaseRetrievalRequest constructions in _agentic_search(). Without this parameter, ref.source_data is always None even when the knowledge source has source_data_fields configured. Fixes microsoft#5095
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_agentic_search()inAzureAISearchContextProviderconstructsKnowledgeBaseRetrievalRequestwithout passingknowledge_source_params, soinclude_reference_source_datais never set. This causesref.source_datato always beNoneon returned references, even when the knowledge source hassource_data_fieldsconfigured.Changes
knowledge_source_params=[KnowledgeSourceParams(..., include_reference_source_data=True)]to bothKnowledgeBaseRetrievalRequestconstructions in_agentic_search()(the minimal reasoning path at line 828 and the non-minimal path at line 836)KnowledgeSourceParamsto bothTYPE_CHECKINGand runtime import blocksTesting
knowledge_source_paramsis present with correctknowledge_source_nameandinclude_reference_source_data=Truefor both the minimal and non-minimal reasoning pathsFixes #5095
This contribution was developed with AI assistance (Claude Code).