-
Notifications
You must be signed in to change notification settings - Fork 864
Python: Feature/fix context provider lifecycle agentic mode #2650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
farzad528
wants to merge
7
commits into
microsoft:main
Choose a base branch
from
farzad528:feature/fix-context-provider-lifecycle-agentic-mode
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
70059df
refactor KB for index creation logic
farzad528 05c5d63
add user agent header for tracking
farzad528 21eab77
fix mypy issues
farzad528 4c7e2f2
Merge branch 'microsoft:main' into main
farzad528 8c62bf7
Merge branch 'microsoft:main' into main
farzad528 6f10b37
fix agentic mode bug for search context provider
farzad528 8f4b1ad
Merge branch 'main' into feature/fix-context-provider-lifecycle-agent…
farzad528 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing test coverage for the multi-turn conversation bug that was fixed. While the fix correctly removes the
async withwrapper that was closing resources after each query, there's no test verifying that multiple consecutive calls toinvoking()work correctly with agentic mode context providers.Consider adding a test that:
__aenter__/__aexit__callsagent.run()__aexit__is only called when the agent's context exits, not after each query