Skip to content

Conversation

@haoliuu
Copy link
Contributor

@haoliuu haoliuu commented Mar 31, 2025

Summary of the Pull Request

Update the Github Action to install .NET 9 to unblock the release

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@haoliuu haoliuu requested a review from a team as a code owner March 31, 2025 23:47
@yeelam-gordon yeelam-gordon requested a review from lei9444 April 1, 2025 01:28
Copy link
Contributor

@yeelam-gordon yeelam-gordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haoliuu , the change should be good for checkin.
@lei9444, I put the comments on we should try out the latest setup-dotnet (@v4) and latest setup-msstore-cli (@v1.1)
We can file an issue and tracking there.

echo powerToysInstallerArm64Url=$(jq -n "$powerToysSetup" | jq -r '[.[]|select(.name | contains("arm64"))][0].browser_download_url') >> $GITHUB_OUTPUT
- name: Setup .NET 9.0
uses: actions/setup-dotnet@v3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like latest is v4, with latest security update, auto cache and more reliable on running.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with:
dotnet-version: '9.0.x'

- uses: microsoft/setup-msstore-cli@v1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably we should also use the 1.1 version of msstore-cli as well.

@haoliuu haoliuu merged commit 721c84d into main Apr 1, 2025
16 checks passed
@haoliuu haoliuu deleted the dev/haoliuu/dotnetfix branch April 1, 2025 08:07
colin-tso pushed a commit to colin-tso/PowerToys that referenced this pull request Apr 8, 2025
@yeelam-gordon yeelam-gordon added the Area-GitHub workflow Issues regarding the GitHub workflow and automation label Jun 10, 2025
sadirano pushed a commit to sadirano/PowerToys that referenced this pull request Jun 10, 2025
@yeelam-gordon yeelam-gordon added this to the PowerToys 0.90 milestone Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-GitHub workflow Issues regarding the GitHub workflow and automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants