[AOT] Update logger to support NativeAOT #40154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Anyone have any concern? |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…ilzh/loggeraot
moooyo
approved these changes
Jul 1, 2025
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yeelam-gordon
added
the
Area-Logging
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the logger implementation to support NativeAOT by replacing FileVersionInfo.GetVersionInfo(Assembly.Location) with a static reflection approach using GetCustomAttribute<AssemblyFileVersionAttribute>()?.Version.
- Removes NativeAOT-incompatible file system access for version information
- Replaces FileVersionInfo usage with assembly attribute reflection
- Eliminates the need for pragma warnings related to single-file publishing
| #pragma warning disable IL3000 // Avoid accessing Assembly file path when publishing as a single file | ||
| private static readonly string Version = FileVersionInfo.GetVersionInfo(Assembly.Location).ProductVersion; | ||
| #pragma warning restore IL3000 // Avoid accessing Assembly file path when publishing as a single file | ||
| private static readonly string Version = Assembly.GetExecutingAssembly().GetCustomAttribute<AssemblyFileVersionAttribute>()?.Version ?? "Unknown"; |
There was a problem hiding this comment.
[nitpick] The fallback value "Unknown" may not provide sufficient information for debugging purposes. Consider using a more descriptive fallback like "Version not available" or including additional context about why the version could not be determined.
Suggested change
| private static readonly string Version = Assembly.GetExecutingAssembly().GetCustomAttribute<AssemblyFileVersionAttribute>()?.Version ?? "Unknown"; | |
| private static readonly string Version = Assembly.GetExecutingAssembly().GetCustomAttribute<AssemblyFileVersionAttribute>()?.Version ?? "Version not available"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Root cause:
FileVersionInfo.GetVersionInfo(Assembly.Location)is not compatible with NativeAOTFix:
Replaced the usage of FileVersionInfo with static reflection
GetCustomAttribute<AssemblyFileVersionAttribute>()?.Version. This uses static reflection to read version metadata directly from the assembly, which is fully supported in NativeAOT. It does not require file system access and is trimming/AOT-safe.PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed