-
Notifications
You must be signed in to change notification settings - Fork 552
Updated packaging format #606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ZviBaratz
wants to merge
5
commits into
microsoft:main
Choose a base branch
from
ZviBaratz:packaging
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9d11352
Updated packaging format
ZviBaratz 4b6a568
Added pip upgrade step to setup block
ZviBaratz 1ce4df4
Merge branch 'main' into packaging
ZviBaratz 0ecb430
Added packages.find block
ZviBaratz ade2333
Merge branch 'main' into packaging
ZviBaratz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| [build-system] | ||
| requires = ["setuptools>=42", "wheel"] | ||
| build-backend = "setuptools.build_meta" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,97 @@ | ||
| [metadata] | ||
| url = https://github.com/microsoft/FLAML | ||
| maintainer = Microsoft Corporation | ||
| maintainer_email = hpo@microsoft.com | ||
| name = FLAML | ||
| version = attr: flaml.version.__version__ | ||
| description = A fast library for automated machine learning and tuning | ||
| long_description = file:README.md | ||
| long_description_content_type = text/markdown; charset=UTF-8 | ||
| license = MIT | ||
| classifiers = | ||
| Programming Language :: Python :: 3 | ||
| License :: OSI Approved :: MIT License | ||
| Operating System :: OS Independent | ||
|
|
||
| [options] | ||
| python_requires = >= 3.7 | ||
| install_requires = | ||
| numpy >= 1.17.0rc1 | ||
| lightgbm >= 2.3.1 | ||
| xgboost >= 0.90 | ||
| scipy >= 1.4.1 | ||
| pandas >= 1.1.4 | ||
| scikit-learn >= 0.24 | ||
| packages = find: | ||
ZviBaratz marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| include_package_data = True | ||
|
|
||
| [options.packages.find] | ||
| include = | ||
| flaml* | ||
|
|
||
| [options.package_data] | ||
| flaml.default = | ||
| */*.json | ||
|
|
||
| [options.extras_require] | ||
| notebook = | ||
| openml == 0.10.2 | ||
| jupyter | ||
| matplotlib | ||
| rgf-python | ||
| catboost >= 0.26 | ||
| test = | ||
| flake8 >= 3.8.4 | ||
| pytest >= 6.1.1 | ||
| coverage >= 5.3 | ||
| pre-commit | ||
| catboost >= 0.26 | ||
| rgf-python | ||
| optuna == 2.8.0 | ||
| vowpalwabbit | ||
| openml | ||
| statsmodels >= 0.12.2 | ||
| psutil == 5.8.0 | ||
| dataclasses | ||
| transformers >= 4.14 | ||
| datasets | ||
| torch | ||
| nltk | ||
| rouge_score | ||
| hcrystalball == 0.1.10 | ||
| seqeval | ||
| protobuf < 4 # to prevent TypeError in ray | ||
| catboost = | ||
| catboost >= 0.26 | ||
| blendsearch = | ||
| optuna == 2.8.0 | ||
| ray = | ||
| ray[tune] ~= 1.10 | ||
| protobuf < 4 # to prevent TypeError in ray | ||
| azureml = | ||
| azureml-mlflow | ||
| nni = | ||
| nni | ||
| vw = | ||
| vowpalwabbit | ||
| nlp = | ||
| transformers >= 4.14 | ||
| datasets | ||
| torch | ||
| seqeval | ||
| nltk | ||
| rouge_score | ||
| ts_forecast = | ||
| holidays < 0.14 # to prevent installation error for prophet | ||
| prophet >= 1.0.1 | ||
| statsmodels >= 0.12.2 | ||
| hcrystalball == 0.1.10 | ||
| forecast = | ||
| holidays < 0.14 # to prevent installation error for prophet | ||
| prophet >= 1.0.1 | ||
| statsmodels >= 0.12.2 | ||
| hcrystalball == 0.1.10 | ||
| benchmark = | ||
| catboost >= 0.26 | ||
| psutil == 5.8.0 | ||
| xgboost == 1.3.3 | ||
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: does this way of packaging support python 3.6? I wanted to allow installation in python 3.6 by changing
>=3.7into>=3.6.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am almost completely positive that there shouldn't be a problem but I can't seem to find anything definitive trying to look it up. Would you like for me to add Python 3.6 to the CI matrix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I knew that CI would not pass in Python 3.6 because an optional dependency (seqeval) doesn't support 3.6 and the test under nlp/ fails. One workaround is to skip those tests in Python 3.6.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then just in terms of replacing setup.py with setup.cfg there shouldn't be a problem, but perhaps it's worth opening a seperate issue for adding support for Python 3.6 and updating this only after the CI is set up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you test the installation at least? No need to test optional dependencies or any unittests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the same command work in a different version of Python?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, running
pip install .from the root directory while a Python 3.9 virtual environment is activated works without a problem.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Is there a way to allow Python 3.6 installation? Though we do not plan to support Python 3.6 in future, I hope to give Python 3.6 users a grace period to be able to install it before they finish the migration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Sorry if you already read my previous comment, I had a mistake, this is the correct status]
I rebuilt the devcontainer with Python 3.6 and could verify the installation is working properly with the original
setup.pybut raising the same exception I was getting before forsetup.cfg. I tried looking up possible causes but unfortunately haven't managed to figure this out so far. Seems like collecting requirements for the wheel build isn't succeeding, but nothing seems to resolve it. I tried adding a minimalsetup.pybut that didn't work either.I guess the options are either to drop support for 3.6 or wait with this PR until that happens.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. If there is no strong reason to change the packaging format now, perhaps we should wait with this PR. In the same time, let's watch the progress of users' migration.