Merged
Conversation
fix: nonWAF to WAF migration fix - Added location param to name to differentiate script name
Avijit-Microsoft
approved these changes
Nov 3, 2025
Contributor
|
🎉 This PR is included in version 3.14.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request updates the naming convention for deployment script modules in
infra/main.bicepto include the deployment location, making script executions more traceable and unique in multi-location scenarios.Naming convention updates for deployment scripts:
nameparameter in theuploadFilesmodule to append the deployment location based on the value ofenablePrivateNetworking, improving uniqueness and traceability.nameparameter in thecreateIndexmodule to include the deployment location for better identification of script executions.nameparameter in thecreateSqlUserAndRolemodule to include the deployment location, ensuring script runs are easily distinguishable by location.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information