Skip to content

fix: merging dev branch to main#636

Merged
Avijit-Microsoft merged 3 commits intomainfrom
dev
Nov 3, 2025
Merged

fix: merging dev branch to main#636
Avijit-Microsoft merged 3 commits intomainfrom
dev

Conversation

@Roopan-Microsoft
Copy link
Contributor

@Roopan-Microsoft Roopan-Microsoft commented Nov 3, 2025

Purpose

This pull request updates the naming convention for deployment script modules in infra/main.bicep to include the deployment location, making script executions more traceable and unique in multi-location scenarios.

Naming convention updates for deployment scripts:

  • Updated the name parameter in the uploadFiles module to append the deployment location based on the value of enablePrivateNetworking, improving uniqueness and traceability.
  • Updated the name parameter in the createIndex module to include the deployment location for better identification of script executions.
  • Updated the name parameter in the createSqlUserAndRole module to include the deployment location, ensuring script runs are easily distinguishable by location.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

Rafi-Microsoft and others added 3 commits October 27, 2025 17:05
fix: nonWAF to WAF migration fix - Added location param to name to differentiate script name
@Avijit-Microsoft Avijit-Microsoft merged commit b57a10f into main Nov 3, 2025
9 checks passed
@github-actions
Copy link
Contributor

🎉 This PR is included in version 3.14.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants