fix(jdbi): publish jdbi bom to consumers#1909
Open
graemerocher wants to merge 2 commits into7.0.xfrom
Open
Conversation
Resolves #839 Co-Authored-By: Codex with GPT-5 <[email protected]>
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Publishes the Jdbi BOM from micronaut-jdbi so downstream consumers can resolve Jdbi artifacts against a consistent, managed version set.
Changes:
- Add the Jdbi3 BOM as an
api(platform(...))dependency inmicronaut-jdbi. - Keep
jdbi3-coreas anapidependency while relying on the BOM for version alignment.
Contributor
Like Copilot comment suggests, it does not bring jdbi3-sqlobject dependency with version from BOM unless explicitly added |
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
micronaut-jdbiso downstream Jdbi modules resolve against the same managed versionjdbi3-coreon the managed version while exporting the BOM transitively for consumersjdbi3-sqlobjectthrough the transitive BOMVerification
./gradlew :micronaut-jdbi:test./gradlew -p /tmp/mn-jdbi-repro-avVwx2 --refresh-dependencies resolveRuntime./gradlew -p /tmp/mn-jdbi-repro-avVwx2 --refresh-dependencies dependencyInsight --dependency org.jdbi:jdbi3-sqlobject --configuration runtimeClasspathResolves #839