Conversation
|
I'd like to add the --with-apt flag to the deploy script yet but this is what I've achieved today |
scripts/configure.py
Outdated
| if "+" in version[2]: | ||
| clean_ver = "" | ||
| i = 0 | ||
| while i < len(version[2]): | ||
| char = version[2][i] | ||
| # When you run the deploy script and have a version numbered like 0.4.9+71ee0f8-UpdateAptFix-dirty, parse 9+71ee0f8-UpdateAptFix-dirty into the non-dirty number | ||
| if char != "+": | ||
| clean_ver += char | ||
| i += 1 | ||
| else: | ||
| version[2] = clean_ver |
There was a problem hiding this comment.
I'm removing this as it's not used or currently useful, but taking note of it since it might be useful in the future
|
There are 4 apt packages missing from the archive that make the version lock necessary: libopusfile0 is used for LMS |
| [tool.poetry] | ||
| name = "amplipi" | ||
| version = "0.4.9" | ||
| version = "0.4.10" |
There was a problem hiding this comment.
We intend to get a release out as soon as this is merged, I'm saving the time of having to also make another discrete bump version PR
scripts/configure.py
Outdated
| return True | ||
| return False | ||
|
|
||
| version = str(_check_version('http://0.0.0.0/api').output).replace("\n", "").replace("using: http://0.0.0.0/api", "").replace("version=", "").split(".") |
There was a problem hiding this comment.
This check is fairly fragile and depends on the exact string that the _check_version spits out.
| version = str(_check_version('http://0.0.0.0/api').output).replace("\n", "").replace("using: http://0.0.0.0/api", "").replace("version=", "").split(".") | |
| version = str(_check_version('http://0.0.0.0/api').output).split("version=", "") | |
| if len(version) > 1: | |
| version = split(version[1]) | |
| else: | |
| version = [0,0,0] |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1073 +/- ##
==========================================
- Coverage 50.67% 50.21% -0.46%
==========================================
Files 40 41 +1
Lines 7154 7362 +208
==========================================
+ Hits 3625 3697 +72
- Misses 3529 3665 +136
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
55a7d6c to
ca664eb
Compare
Add version gating, apt source list editing to configure.py Update ethcer docs to use 0.4.8 image
6cdc36a to
9d4016c
Compare
What does this change intend to accomplish?
Make the updater check the version the system is running before update and say no if less than
0.4.0Add --with-apt flag to configure.py
Update imaging directions with config retention to reduce some user pain
Checklist
./scripts/test