Disconnect zones from source when stream disconnects#1048
Open
SteveMicroNova wants to merge 3 commits intomainfrom
Open
Disconnect zones from source when stream disconnects#1048SteveMicroNova wants to merge 3 commits intomainfrom
SteveMicroNova wants to merge 3 commits intomainfrom
Conversation
linknum23
reviewed
Jun 2, 2025
Contributor
linknum23
left a comment
There was a problem hiding this comment.
This directly couples the set_zone and set_source api calls and feels more like something that we might add as higher level concept later if we ever make a concept similar to a play session. Can this just be implemented on the HA side for now?
Contributor
Author
Yes, but that leaves room for errors when a user clicks the X to close out a stream on the AmpliPi webapp. That particular React component doesn't have enough state to call after the zones to disconnect them along the way, and it seemed better to implement in the backend rather than doing it across two different codebases |
aa48848 to
fbc2c17
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change intend to accomplish?
Disconnects zones from source when stream disconnects from the same source. This is useful because leaving zones and groups secretly connected in the background had some potential conflicts with home assistant automations
Checklist
./scripts/test