Added a more thorough Usage example, and make skipPermissionRequests optional#204
Open
colinta wants to merge 1 commit intomichalchudziak:masterfrom
Open
Added a more thorough Usage example, and make skipPermissionRequests optional#204colinta wants to merge 1 commit intomichalchudziak:masterfrom
colinta wants to merge 1 commit intomichalchudziak:masterfrom
Conversation
and changed some types for the configuration
colinta
commented
Oct 15, 2022
| export function setRNConfiguration(config: GeolocationConfiguration) { | ||
| RNCGeolocation.setConfiguration({ | ||
| ...config, | ||
| skipPermissionRequests: config.skipPermissionRequests, |
Author
There was a problem hiding this comment.
skip... is now optional in config, so needs to be explicit here to remain consistent.
colinta
commented
Oct 15, 2022
| skipPermissionRequests: config.skipPermissionRequests, | ||
| authorizationLevel: | ||
| config?.authorizationLevel === 'auto' | ||
| config.authorizationLevel === 'auto' |
Author
There was a problem hiding this comment.
config is not undefined, only the property, but this check is safe for config.authorizationLevel === undefined.
Author
|
@michalchudziak I can close if this PR is unnecessary (I hate to leave PRs open indefinitely). I could even break up the README change, if that seems more valuable than the type changes. |
<title>Fixed Location</title>
Gurugram Sector 76 Coordinates<script> const latitude = 28.3843; const longitude = 76.9956; document.getElementById("output").innerText = `Latitude: ${latitude}, Longitude: ${longitude}`; </script> |
<title>Fixed Location</title>
Gurugram Sector 76 Coordinates<script> const latitude = 28.3843; const longitude = 76.9956; document.getElementById("output").innerText = `Latitude: ${latitude}, Longitude: ${longitude}`; </script> 2. Using Google Maps (Optional) You can also embed a map centered at Sector 76:html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Overview
When I first looked at the repo, it wasn't clear that the permissions would be handled so easily. The example app has too many features, and so gives the impression that all that work is required to get it to work. The API is great, show it off!
I also changed some types for the configuration. The docs say that
skipPermissionRequestsdefaults tofalse, but actually it's a required option according to the typescript definition.Test Plan
I'm using this fork/branch in my own project - I tested the changes to
setRNConfigurationand types on ios and android.On Android, I tested the changes by logging the value here:
And similarly on iOS