Open
Conversation
mguessan
added a commit
that referenced
this pull request
Mar 1, 2026
git-svn-id: https://svn.code.sf.net/p/davmail/code/trunk@3965 3d1905a2-6b24-0410-a738-b14d5a86fcbd
mguessan
added a commit
that referenced
this pull request
Mar 1, 2026
git-svn-id: https://svn.code.sf.net/p/davmail/code/trunk@3966 3d1905a2-6b24-0410-a738-b14d5a86fcbd
Owner
|
Thanks for your contribution, I refactored your code a bit to use RestRequest to handle JSON response. Can you please confirm merged code is working as expected ? |
Author
|
Thanks! I tried davmail from master but it seems that no |
meeuw
force-pushed
the
device-code-authenticator
branch
from
fef9e23 to
781a209
Compare
Author
|
I got the master branch working! I had to configure I'm not sure if you intentionally left out the changes in 781a209, I updated this PR to include it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Device code authentication is a bit different from call back authentication as for device code authentication a (short) code has to be copied from davmail to the web browser.
The advantages of this are a slightly better user experience and some appid's don't allow/support call back authentication.
I think davmail could be refactored a bit to make these changes a bit more clean (make the call back url optional, make a resource a single definition, move json parsing)
Please let me know what you think of this.