Allow sending HTTP origin header for token requests#441
Open
jimdigriz wants to merge 1 commit intomguessan:masterfrom
Open
Allow sending HTTP origin header for token requests#441jimdigriz wants to merge 1 commit intomguessan:masterfrom
jimdigriz wants to merge 1 commit intomguessan:masterfrom
Conversation
|
I think you (accidentally?) included the Graph fix in this PR, @jimdigriz. This PR should only have the Origin commit. |
Not providing an origin can lead to: ERROR [ImapConnection-48912] davmail.exchange.auth.O365Token - refresh token failed invalid_request AADSTS9002327: Tokens issued for the 'Single-Page Application' client-type may only be redeemed via cross-origin requests. Trace ID: ... Correlation ID: ... Timestamp: ...
jimdigriz
force-pushed
the
token-origin
branch
from
6a6ecc8 to
48e8528
Compare
Author
|
Doh, resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some client ID's, in particularly Single Page Applications (SPAs), require that an HTTP
originheader be sent to be able to exchange your code/refresh_token for an access token.This PR allows this, discovered whilst working through #440.
To be applied after #439, this commit was originally part of that PR but it was requested that it be broken out.