Open
Conversation
meta-cla
bot
added
the
CLA Signed
SuhitK
added a commit
to SuhitK/torchcomms
that referenced
this pull request
Feb 11, 2026
Summary: This diff adds structured IB completion error reporting from the transport layer (net_ib.cc) to the NCCLX comms analyzer thrift service (GetCommsResponse). Errors are stored in the process-global ProcessGlobalErrorsUtil singleton and read directly by the handler. Each error is reported only once: the handler flushes the IB error state after populating the response. IB errors are per-rank, not per-communicator, so ibErrors is a top-level field on GetCommsResponse. The handler reads from ProcessGlobalErrorsUtil::getAllState() directly, bypassing the per-comm commDump.cc serialization path. Differential Revision: D92873340
SuhitK
force-pushed
the
export-D92873340
branch
2 times, most recently
from
196881f to
b461090
Compare
SuhitK
added a commit
to SuhitK/torchcomms
that referenced
this pull request
Feb 18, 2026
Summary: This diff adds structured IB completion error reporting from the transport layer (net_ib.cc) to the NCCLX comms analyzer thrift service (GetCommsResponse). Errors are stored in the process-global ProcessGlobalErrorsUtil singleton and read directly by the handler. Each error is reported only once: the handler flushes the IB error state after populating the response. IB errors are per-rank, not per-communicator, so ibErrors is a top-level field on GetCommsResponse. The handler reads from ProcessGlobalErrorsUtil::getAllState() directly, bypassing the per-comm commDump.cc serialization path. Reviewed By: YulunW Differential Revision: D92873340
SuhitK
added a commit
to SuhitK/torchcomms
that referenced
this pull request
Feb 18, 2026
Summary: This diff adds structured IB completion error reporting from the transport layer (net_ib.cc) to the NCCLX comms analyzer thrift service (GetCommsResponse). Errors are stored in the process-global ProcessGlobalErrorsUtil singleton and read directly by the handler. Each error is reported only once: the handler flushes the IB error state after populating the response. IB errors are per-rank, not per-communicator, so ibErrors is a top-level field on GetCommsResponse. The handler reads from ProcessGlobalErrorsUtil::getAllState() directly, bypassing the per-comm commDump.cc serialization path. Reviewed By: YulunW Differential Revision: D92873340
SuhitK
added a commit
to SuhitK/torchcomms
that referenced
this pull request
Feb 19, 2026
Summary: This diff adds structured IB completion error reporting from the transport layer (net_ib.cc) to the NCCLX comms analyzer thrift service (GetCommsResponse). Errors are stored in the process-global ProcessGlobalErrorsUtil singleton and read directly by the handler. Each error is reported only once: the handler flushes the IB error state after populating the response. IB errors are per-rank, not per-communicator, so ibErrors is a top-level field on GetCommsResponse. The handler reads from ProcessGlobalErrorsUtil::getAllState() directly, bypassing the per-comm commDump.cc serialization path. Reviewed By: YulunW Differential Revision: D92873340
SuhitK
added a commit
to SuhitK/torchcomms
that referenced
this pull request
Feb 20, 2026
Summary: This diff adds structured IB completion error reporting from the transport layer (net_ib.cc) to the NCCLX comms analyzer thrift service (GetCommsResponse). Errors are stored in the process-global ProcessGlobalErrorsUtil singleton and read directly by the handler. Each error is reported only once: the handler flushes the IB error state after populating the response. IB errors are per-rank, not per-communicator, so ibErrors is a top-level field on GetCommsResponse. The handler reads from ProcessGlobalErrorsUtil::getAllState() directly, bypassing the per-comm commDump.cc serialization path. Reviewed By: YulunW Differential Revision: D92873340
SuhitK
force-pushed
the
export-D92873340
branch
from
b461090 to
fbfc946
Compare
SuhitK
added a commit
to SuhitK/torchcomms
that referenced
this pull request
Feb 20, 2026
Summary: This diff adds structured IB completion error reporting from the transport layer (net_ib.cc) to the NCCLX comms analyzer thrift service (GetCommsResponse). Errors are stored in the process-global ProcessGlobalErrorsUtil singleton and read directly by the handler. Each error is reported only once: the handler flushes the IB error state after populating the response. IB errors are per-rank, not per-communicator, so ibErrors is a top-level field on GetCommsResponse. The handler reads from ProcessGlobalErrorsUtil::getAllState() directly, bypassing the per-comm commDump.cc serialization path. Reviewed By: YulunW Differential Revision: D92873340
SuhitK
added a commit
to SuhitK/torchcomms
that referenced
this pull request
Feb 20, 2026
Summary: This diff adds structured IB completion error reporting from the transport layer (net_ib.cc) to the NCCLX comms analyzer thrift service (GetCommsResponse). Errors are stored in the process-global ProcessGlobalErrorsUtil singleton and read directly by the handler. Each error is reported only once: the handler flushes the IB error state after populating the response. IB errors are per-rank, not per-communicator, so ibErrors is a top-level field on GetCommsResponse. The handler reads from ProcessGlobalErrorsUtil::getAllState() directly, bypassing the per-comm commDump.cc serialization path. Reviewed By: YulunW Differential Revision: D92873340
SuhitK
force-pushed
the
export-D92873340
branch
from
fbfc946 to
f6e1cba
Compare
SuhitK
added a commit
to SuhitK/torchcomms
that referenced
this pull request
Feb 21, 2026
Summary: This diff adds structured IB completion error reporting from the transport layer (net_ib.cc) to the NCCLX comms analyzer thrift service (GetCommsResponse). Errors are stored in the process-global ProcessGlobalErrorsUtil singleton and read directly by the handler. Each error is reported only once: the handler flushes the IB error state after populating the response. IB errors are per-rank, not per-communicator, so ibErrors is a top-level field on GetCommsResponse. The handler reads from ProcessGlobalErrorsUtil::getAllState() directly, bypassing the per-comm commDump.cc serialization path. Reviewed By: YulunW Differential Revision: D92873340
SuhitK
added a commit
to SuhitK/torchcomms
that referenced
this pull request
Feb 21, 2026
Summary: This diff adds structured IB completion error reporting from the transport layer (net_ib.cc) to the NCCLX comms analyzer thrift service (GetCommsResponse). Errors are stored in the process-global ProcessGlobalErrorsUtil singleton and read directly by the handler. Each error is reported only once: the handler flushes the IB error state after populating the response. IB errors are per-rank, not per-communicator, so ibErrors is a top-level field on GetCommsResponse. The handler reads from ProcessGlobalErrorsUtil::getAllState() directly, bypassing the per-comm commDump.cc serialization path. Reviewed By: YulunW Differential Revision: D92873340
Summary: Pull Request resolved: meta-pytorch#630 This diff adds structured IB completion error reporting from the transport layer (net_ib.cc) to the NCCLX comms analyzer thrift service (GetCommsResponse). Errors are stored in the process-global ProcessGlobalErrorsUtil singleton and read directly by the handler. Each error is reported only once: the handler flushes the IB error state after populating the response. IB errors are per-rank, not per-communicator, so ibErrors is a top-level field on GetCommsResponse. The handler reads from ProcessGlobalErrorsUtil::getAllState() directly, bypassing the per-comm commDump.cc serialization path. Reviewed By: YulunW Differential Revision: D92873340
SuhitK
force-pushed
the
export-D92873340
branch
from
f6e1cba to
2a61682
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This diff adds structured IB completion error reporting from the transport layer (net_ib.cc) to the NCCLX comms analyzer thrift service (GetCommsResponse). Errors are stored in the process-global ProcessGlobalErrorsUtil singleton and read directly by the handler. Each error is reported only once: the handler flushes the IB error state after populating the response.
IB errors are per-rank, not per-communicator, so ibErrors is a top-level field on GetCommsResponse. The handler reads from ProcessGlobalErrorsUtil::getAllState() directly, bypassing the per-comm commDump.cc serialization path.
Differential Revision: D92873340