Add missing argument documentation for 4 methods#1786
Closed
cyrjano wants to merge 1 commit intometa-pytorch:masterfrom
Closed
Add missing argument documentation for 4 methods#1786cyrjano wants to merge 1 commit intometa-pytorch:masterfrom
cyrjano wants to merge 1 commit intometa-pytorch:masterfrom
Conversation
Summary: Added documentation for missing arguments in 4 methods where other arguments were already documented: - TCAV.__init__: Added `attribute_to_layer_input` documentation - SimilarityInfluence.__init__: Added `similarity_direction` documentation - NeuronConductance.attribute: Added `grad_kwargs` documentation - TracInCPBase.influence: Added `unpack_inputs` documentation These were identified by analyzing the RST documentation files and comparing them with the actual method signatures in the source code. Differential Revision: D92080047
Contributor
Contributor
|
This pull request has been merged in 275d8a0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Added documentation for missing arguments in 4 methods where other arguments
were already documented:
attribute_to_layer_inputdocumentationsimilarity_directiondocumentationgrad_kwargsdocumentationunpack_inputsdocumentationThese were identified by analyzing the RST documentation files and comparing
them with the actual method signatures in the source code.
Differential Revision: D92080047