Adds configuration for OAuth library's authentication style.#66
Open
Obirah wants to merge 1 commit intomesosphere:masterfrom
Open
Adds configuration for OAuth library's authentication style.#66Obirah wants to merge 1 commit intomesosphere:masterfrom
Obirah wants to merge 1 commit intomesosphere:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull requests adds the possibility to configure the OAuth library's authentication style. Some OAuth providers don't support the auto detection that is used by default (e.g. AWS Cognito).
I already contributed this to the original traefik-forward-auth. As it was never merged and the project seems to be dead right now, I want to contribute the feature here and move to the mesosphere fork in my environment.
As I'm not a pro in golang yet, I wasn't sure if there is any smart test scenario that could be added to
server_test.go(e.g. something that tests the auth style is correct in the request). If you have any ideas/suggestions, please let me know and I will adapt it as well.