feat: enable WAL connection pool for parallel reads#5372
Open
jamesarich wants to merge 1 commit intomainfrom
Open
feat: enable WAL connection pool for parallel reads#5372jamesarich wants to merge 1 commit intomainfrom
jamesarich wants to merge 1 commit intomainfrom
Conversation
Room 3.0.0-alpha04 adds setMultipleConnectionPool(). Enable it with 4 readers / 1 writer to allow concurrent read operations (paging, multiple Flow collectors) without contention. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables Room 3’s multi-connection pool on the shared RoomDatabase.Builder configuration to allow parallel reads while writes are in progress (WAL-mode), improving responsiveness under concurrent database access (e.g., message list + search + sync).
Changes:
- Enable
setMultipleConnectionPool(maxNumOfReaders = 4, maxNumOfWriters = 1)in the project’s common Room builder configuration. - Keep existing destructive-migration fallback and query coroutine context configuration intact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables Room's
setMultipleConnectionPool()(new in Room 3.0.0-alpha04) for WAL-mode databases.Changes
configureCommon()Impact