fix(dia): open options page via extension tab#1373
Conversation
🦋 Changeset detectedLatest commit: aa061a8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor trust score94/100 — Highly trusted This score estimates contributor familiarity with Outcome
Score breakdown
Signals used
Policy
Updated automatically when the PR changes or when a maintainer reruns the workflow. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aa061a8342
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "lint": "eslint", | ||
| "lint:fix": "eslint --fix", | ||
| "postinstall": "wxt prepare", | ||
| "postinstall": "WXT_SKIP_ENV_VALIDATION=true wxt prepare", |
There was a problem hiding this comment.
Make postinstall env override cross-platform
The new postinstall command uses POSIX inline env assignment (WXT_SKIP_ENV_VALIDATION=true wxt prepare), which fails under the default Windows npm/pnpm script shell (cmd.exe), so pnpm install now breaks for Windows contributors/CI before dependencies finish installing. This regression was introduced by this commit; use a cross-platform approach (e.g., cross-env) to preserve install behavior across OSes.
Useful? React with 👍 / 👎.
Type of Changes
Description
This PR fixes opening the extension options page in Dia by avoiding
browser.runtime.openOptionsPage()and opening the extension options entry directly withbrowser.tabs.create({ url: browser.runtime.getURL("/options.html") }).It also makes
postinstallskip required production env validation while runningwxt prepare, so local installs do not require production-onlyWXT_*values.Related Issue
N/A
How Has This Been Tested?
Commands run:
pnpm run postinstallSKIP_FREE_API=true pnpm exec vitest run src/utils/__tests__/navigation.test.tspnpm exec eslint package.json src/utils/navigation.ts src/utils/__tests__/navigation.test.ts src/entrypoints/background/index.ts src/entrypoints/popup/app.tsxWXT_SKIP_ENV_VALIDATION=true pnpm buildpnpm exec tsc --noEmitnx run @read-frog/extension:lint,nx run @read-frog/extension:type-check,nx run @read-frog/extension:testScreenshots
N/A
Checklist
Additional Information
The local
web-ext.config.tsfor Dia remains ignored by git as intended.