refactor(subtitles): replace route-based navigation with flat panel navigator#1368
Merged
refactor(subtitles): replace route-based navigation with flat panel navigator#1368
Conversation
…avigator Replace the multi-file route system (routes/defs.ts, routes/config.tsx, routes/index.ts) with a single-source-of-truth views/ directory using flat ViewId strings instead of path-style RoutePath. - Merge route definitions, metadata, and component map into views/index.tsx - Make PanelShell purely presentational (header? + transition? props) - Simplify translate button onClick to one-line reset + toggle - Rename SubtitlesSettingsAction to SubpageMenuEntry - Extract panel dismiss logic into dedicated hook Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 895f526 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
Bot
added
refactor
contrib-trust:trusted
Contributor
Contributor trust score73/100 — Trusted This score estimates contributor familiarity with Outcome
Score breakdown
Signals used
Policy
Updated automatically when the PR changes or when a maintainer reruns the workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Refactor the subtitles settings panel from a flat component structure into a view-based panel navigator, preparing for future submenus (e.g., subtitle style settings).
Key changes:
views/directory as single source of truth for panel navigation (ViewId,SUBPAGESconfig, component registry)settings-panel-shell.tsxwith a presentationalpanel-shell.tsxthat receives resolvedheader?andtransition?propsSubpageMenuEntrycomponent for navigable submenu entriesuse-subtitles-panel-dismisshooksubtitlesSettingsPanelViewAtomto track current view, with reset on panel close and video navigationAdding a new subpage now requires:
ViewIdtypeSUBPAGESarrayNo other files need to change — main menu picks it up automatically.
How Has This Been Tested?
pnpm type-check)pnpm test)Checklist