Skip to content

fix: floating button style#1321

Merged
mengxi-ream merged 1 commit intomengxi-ream:mainfrom
yioulii:fix/floating-button-style
Apr 13, 2026
Merged

fix: floating button style#1321
mengxi-ream merged 1 commit intomengxi-ream:mainfrom
yioulii:fix/floating-button-style

Conversation

@yioulii
Copy link
Copy Markdown
Contributor

@yioulii yioulii commented Apr 12, 2026

Type of Changes

  • ✨ New feature (feat)
  • πŸ› Bug fix (fix)
  • πŸ“ Documentation change (docs)
  • [βœ…] πŸ’„ UI/style change (style)
  • ♻️ Code refactoring (refactor)
  • ⚑ Performance improvement (perf)
  • βœ… Test related (test)
  • πŸ”§ Build or dependencies update (build)
  • πŸ”„ CI/CD related (ci)
  • 🌐 Internationalization (i18n)
  • 🧠 AI model related (ai)
  • πŸ”„ Revert a previous commit (revert)
  • πŸ“¦ Other changes that do not modify src or test files (chore)

Description

adjusted floating button style and added shadow to translation button and settings button

Related Issue

#1255

Closes #

How Has This Been Tested?

  • Added unit tests
  • [βœ…] Verified through manual testing

Screenshots

Checklist

  • I have tested these changes locally
  • I have updated the documentation accordingly if necessary
  • My code follows the code style of this project
  • My changes do not break existing functionality
  • If my code was generated by AI, I have proofread and improved it as necessary.

Additional Information


Summary by cubic

Fixes floating button styling to improve spacing and visibility. Adds shadows to the translate and settings buttons and tightens layout for cleaner alignment.

  • Bug Fixes
    • Add shadow to hidden action buttons (translate, settings).
    • Adjust container width/offset and logo margin for consistent alignment.

Written for commit 15ea6c5. Summary will update on new commits.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 12, 2026

πŸ¦‹ Changeset detected

Latest commit: 15ea6c5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@read-frog/extension Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added fix contrib-trust:new PR author trust score is 0-29. needs-maintainer-review Contributor trust automation recommends maintainer review. labels Apr 12, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Contributor trust score

9/100 β€” New contributor

This score estimates contributor familiarity with mengxi-ream/read-frog using public GitHub signals. It is advisory only and does not block merges automatically.

Outcome

  • PR: fix: floating button styleΒ #1321 β€” fix: floating button style
  • Author: @yioulii
  • Trust label: contrib-trust:new
  • Maintainer review: required
  • Override label: add trust-check:skip to stop future trust automation updates

Score breakdown

Dimension Score Signals
Repo familiarity 0/35 commits in repo, merged PRs, reviews
Community standing 4/25 account age, followers, repo role
OSS influence 0/20 stars on owned non-fork repositories
PR track record 5/20 merge rate across resolved PRs in this repo

Signals used

  • Repo commits: 0 (author commits reachable from the repository default branch)
  • Repo PR history: merged 0, open 1, closed-unmerged 0
  • Repo reviews: 0
  • PR changed lines: 13 (+9 / -4)
  • Repo permission: read
  • Followers: 0
  • Account age: 18 months
  • Owned non-fork repos considered: max 0, total 0 (none)

Policy

  • Low-score review threshold: < 30
  • Auto-close: score < 20 and changed lines > 1000
  • Policy version: v1.1

Updated automatically when the PR changes or when a maintainer reruns the workflow.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 3 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid β€” if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name=".changeset/solid-cases-stop.md">

<violation number="1" location=".changeset/solid-cases-stop.md:2">
P2: Changeset frontmatter omits required `extensionVersion` metadata, so notification targeting can be incorrect for this release.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

@@ -0,0 +1,5 @@
---
"@read-frog/extension": patch
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Changeset frontmatter omits required extensionVersion metadata, so notification targeting can be incorrect for this release.

Prompt for AI agents
Check if this issue is valid β€” if so, understand the root cause and fix it. At .changeset/solid-cases-stop.md, line 2:

<comment>Changeset frontmatter omits required `extensionVersion` metadata, so notification targeting can be incorrect for this release.</comment>

<file context>
@@ -0,0 +1,5 @@
+---
+"@read-frog/extension": patch
+---
+
</file context>
Fix with Cubic

@frogGuaGuaGuaGua
Copy link
Copy Markdown
Collaborator

Demo video for the floating button style change:

  • First half: origin/main
  • Second half: this PR (fix/floating-button-style)
  • Page: https://example.com
  • Viewport: 900x700
  • Interaction: hover the floating button to reveal the translate/settings buttons

Preview image:

PR #1321 floating button preview

Video:

What the demo highlights:

  • the hidden translate/settings buttons now have a visible shadow (shadow-lg)
  • the main floating button is slightly tighter/narrower and offset a bit less when tucked to the right edge

@mengxi-ream mengxi-ream merged commit fb1937c into mengxi-ream:main Apr 13, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contrib-trust:new PR author trust score is 0-29. fix needs-maintainer-review Contributor trust automation recommends maintainer review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants