fix: GROUP_CONCAT returns incorrect result for JSON type (#23462) #23573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n#23462) The GROUP_CONCAT function was using concatVar for JSON type which directly appends raw bytejson binary format instead of readable JSON string. Added dedicated concatJson function to properly decode bytejson and convert to JSON string output.
LeftHandCold
force-pushed
the
fix_GROUP_CONCAT
branch
from
df3eb26 to
f746093
Compare
ouyuanning
approved these changes
Jan 22, 2026
aunjgr
approved these changes
Jan 23, 2026
Contributor
Merge Queue Status🚫 The pull request has left the queue (rule: This pull request spent 58 minutes 49 seconds in the queue, with no time running CI. Required conditions to merge
ReasonThe merge conditions cannot be satisfied due to failing checks HintYou may have to fix your CI before adding the pull request to the queue again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue #23462
What this PR does / why we need it:
The GROUP_CONCAT function was using concatVar for JSON type which directly appends raw bytejson binary format instead of readable JSON string. Added dedicated concatJson function to properly decode bytejson and convert to JSON string output.