Check for contributory behavior in our 3DH and double ratchet implementations#298
Open
Check for contributory behavior in our 3DH and double ratchet implementations#298
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #298 +/- ##
==========================================
+ Coverage 90.71% 91.05% +0.33%
==========================================
Files 34 34
Lines 4965 4984 +19
Branches 4965 4984 +19
==========================================
+ Hits 4504 4538 +34
+ Misses 297 280 -17
- Partials 164 166 +2 ☔ View full report in Codecov by Sentry. |
poljar
force-pushed
the
poljar/was-contributory
branch
2 times, most recently
from
3078c72 to
e09af80
Compare
This ensures that wherever the Curve25519SecretKey type is used, we're also checking for contributory behavior of the public key.
soatok
reviewed
Feb 19, 2026
|
|
||
| let message = "It's a secret to everybody"; | ||
| let olm_message: LibolmOlmMessage = alice_session.encrypt(message).into(); | ||
| let olm_message: LibolmOlmMessage = alice_session.encrypt(message).unwrap().into(); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Collaborator
Author
There was a problem hiding this comment.
To remove confusion in case other passer-by readers arrive, tests and benchmarks are using unwrap() calls.
As to why #297 wasn't complete:
- It introduced a new private API which does the
was_contributory()check. - It marked the existing private API as deprecated.
- The rest of the 3DH implementation would have still used the method without the
was_contributory()check. - The double ratchet implementation does a Diffie-Hellman computation as well, which wasn't modified to do a
was_contributory()check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.