Skip to content

fix(Datepicker): unexpected close on calendar interaction #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wuda-io merged 5 commits into from
Jul 14, 2025
Merged

fix(Datepicker): unexpected close on calendar interaction #630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
849ae54
fix(Datepicker) fixes bug where modal closes on calendar interaction
gselderslaghs Jun 25, 2025
b86132a
Revert "fix(Datepicker) fixes bug where modal closes on calendar inte…
gselderslaghs Jul 11, 2025
50b6a1c
fix(displayPlugin) set event propagation to capture in display plugin…
gselderslaghs Jul 11, 2025
9ee7649
feat(Pickers/DisplayPlugin) fix failing spectest
gselderslaghs Jun 29, 2025
fc27a05
revert hunk from 50b6a1c3
gselderslaghs Jul 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions components/datepicker/datepickerSpec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,14 +136,14 @@ describe('Datepicker Plugin', () => {
setTimeout(() => {
expect(input.value)
.withContext('value should change with confirm interaction')
.toEqual(`${month < 10 ? `0${month}` : month}/0${day}/${year}`);
.toEqual(`${month < 10 ? `0${month}` : month}/${day < 10 ? '0' + day : day}/${year}`);
dayEl = document.querySelector('.datepicker-container button[data-day="1"]');
dayEl.dispatchEvent(new MouseEvent('click', { bubbles: true, cancelable: true }));
cancelBtn.dispatchEvent(new MouseEvent('click', { bubbles: true, cancelable: true }));
setTimeout(() => {
expect(input.value)
.withContext('value should not change with cancel interaction')
.toEqual(`${month < 10 ? `0${month}` : month}/0${day}/${year}`);
.toEqual(`${month < 10 ? `0${month}` : month}/${day < 10 ? '0' + day : day}/${year}`);
clearBtn.dispatchEvent(new MouseEvent('click', { bubbles: true, cancelable: true }));
setTimeout(() => {
expect(input.value.length)
Expand All @@ -156,7 +156,7 @@ describe('Datepicker Plugin', () => {
}, 10);
}, 10);
}, 10);
});
}, 10);
});
});
});
2 changes: 1 addition & 1 deletion src/dockedDisplayPlugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export class DockedDisplayPlugin {
) {
this.hide();
}
});
}, true);
}

/**
Expand Down