enable autocomplete to accept dropdown options

[nicknickel]

Proposed changes

• This PR implements Autocomplete respect dropdownOptions. Fix placement when container is… Dogfalo/materialize#6602 to enable the autocomplete component to take dropdown options.
  • Note: This does not implement the styling piece of that PR which alters the dropdown style if the container is document.body.
• This is also mentioned on the list of PRs to merge and in bug: materialize select in modal #35.

Types of changes

• Bug fix (non-breaking change which fixes an issue).
• New feature (non-breaking change which adds functionality).
• Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

• I have read the CONTRIBUTING document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

[DanielRuf]

LGTM

[Smankusors]

Looks fine from me. 👍

On the other side, I just found on the "select" documentation, there's additional documentation on Properties section. But... The name and description IMO doesn't make sense... More like... it tries to use existing variable but for different purpose? 😕

materialize/jade/page-contents/select_content.html

Lines 284 to 288 in 88fa44a

	<tr>
	<td>dropdownOptions</td>
	<td>Element</td>
	<td>Dropdown UL element.</td>
	</tr>

[nicknickel]

@Smankusors - I didn't notice that it. I used the select component as a reference when making this change and did notice that "dropdownOptions" is used for different purposes and is only differentiated by location / scope. Below is where the options that are passed to the dropdown component are used. The dropdownOptions in the documentation you linked are a property of the select component itself, not it's options, if that makes sense.

materialize/js/select.js

Line 243 in 88fa44a

let dropdownOptions = $.extend({}, this.options.dropdownOptions);

In any case, it probably would be good to rename one of those "dropdownOptions" on the select component to clear up confusion. Maybe something for a new release since that would probably be a breaking change?

[DanielRuf]

In any case, it probably would be good to rename one of those "dropdownOptions" on the select component to clear up confusion. Maybe something for a new release since that would probably be a breaking change?

👍

[doughballs]

@Smankusors - I didn't notice that it. I used the select component as a reference when making this change and did notice that "dropdownOptions" is used for different purposes and is only differentiated by location / scope. Below is where the options that are passed to the dropdown component are used. The dropdownOptions in the documentation you linked are a property of the select component itself, not it's options, if that makes sense.

materialize/js/select.js

Line 243 in 88fa44a

let dropdownOptions = $.extend({}, this.options.dropdownOptions);

In any case, it probably would be good to rename one of those "dropdownOptions" on the select component to clear up confusion. Maybe something for a new release since that would probably be a breaking change?

This confused me for a long time but actually, they named it perfectly - dropdownOptions are in fact ‘the options of the dropdown’, as opposed to say, selectOptions, which might refer to setting the <option> programmatically.

This would be a good feature add, along with allowing extra data to be passed to autocomplete - two use cases I come up against fairly frequently in the Gitter channel.

[Smankusors]

In any case, it probably would be good to rename one of those "dropdownOptions" on the select component to clear up confusion. Maybe something for a new release since that would probably be a breaking change?

that would be a documentation improvement, and IMO should be a separate PR for that.

This confused me for a long time but actually, they named it perfectly - dropdownOptions are in fact ‘the options of the dropdown’, as opposed to say, selectOptions, which might refer to setting the <option> programmatically.

This would be a good feature add, along with allowing extra data to be passed to autocomplete - two use cases I come up against fairly frequently in the Gitter channel.

hmm makes sense.

---

aside from that, is this PR okay to merge?

[nicknickel]

Not sure who you are asking but, from my perspective, this PR is ok to be merged.

[DanielRuf]

Thanks for the reviews, I'll merge it now.