feat(icon): nginx folder icon#3197
Open
lorypelli wants to merge 1 commit intomaterial-extensions:mainfrom
Open
feat(icon): nginx folder icon#3197lorypelli wants to merge 1 commit intomaterial-extensions:mainfrom
lorypelli wants to merge 1 commit intomaterial-extensions:mainfrom
Conversation
Signed-off-by: RVG|lory <[email protected]>
Member
|
I think you've missed the svg files for the icon in your commit. |
Contributor
Author
Isn't it the same as the other one for file icon? |
Member
|
@lorypelli you have to create new SVG files for the folders. We don't pick up the file icons automatically. This PR requires:
You can find more details in our contribution guidelines: https://github.com/material-extensions/vscode-material-icon-theme/blob/main/CONTRIBUTING.md#create-icon-as-svg Feel free to ask if you need further support! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added icon if the folder is named
nginx(likephpdoes have)Contribution Guidelines