Restore expanded state persistence for custom class properties#4493
Open
Oval17 wants to merge 1 commit intomapeditor:masterfrom
Open
Restore expanded state persistence for custom class properties#4493Oval17 wants to merge 1 commit intomapeditor:masterfrom
Oval17 wants to merge 1 commit intomapeditor:masterfrom
Conversation
The mExpandedProperties field was declared in VariantMapProperty but never used after the list-properties refactoring in mapeditor#4002. This restores the logic: class properties start collapsed and the user's expand/collapse choices are remembered within the session. When properties are recreated (e.g. due to type changes or object switching), the expanded state is restored from the in-memory set. Fixes mapeditor#4035
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @bjorn @joereynolds
This PR Fixes #4035
I have changed, verified and tested the following things
setupExpandedStateis called when a new class GroupProperty is createdmExpandedProperties(empty set → defaults to collapsed, matching the maintainer's requirement)expandedChangedto update the set reactivelyReady for inputs and Review.
Thanks