Skip to content

Comments

Prevent accidental scrolling of combo boxes in new Instrument View#40834

Merged
RichardWaiteSTFC merged 2 commits intomantidproject:mainfrom
jclarkeSTFC:stop_accidental_combo_scrolling_iv
Feb 9, 2026
Merged

Prevent accidental scrolling of combo boxes in new Instrument View#40834
RichardWaiteSTFC merged 2 commits intomantidproject:mainfrom
jclarkeSTFC:stop_accidental_combo_scrolling_iv

Conversation

@jclarkeSTFC
Copy link
Contributor

@jclarkeSTFC jclarkeSTFC commented Feb 5, 2026

This stops the combo boxes scrolling if they happen to fall underneath your mouse pointer while using the mouse scroll wheel, which is behaviour that I find upsetting.

To test:

Move your mouse pointer over a combo box in the new Instrument View and scroll the mouse wheel, the option should not change.


Reviewer

Your comments will be used as part of the gatekeeper process. Comment clearly on what you have checked and tested during your review. Provide an audit trail for any changes requested.

As per the review guidelines:

  • Is the code of an acceptable quality? (Code standards/GUI standards)
  • Has a thorough functional test been performed? Do the changes handle unexpected input/situations?
  • Are appropriately scoped unit and/or system tests provided?
  • Do the release notes conform to the guidelines and describe the changes appropriately?
  • Has the relevant (user and developer) documentation been added/updated?
  • If the PR author isn’t in the mantid-developers or mantid-contributors teams, add a review comment rerun ci to authorize/rerun the CI

Gatekeeper

As per the gatekeeping guidelines:

  • Has a thorough first line review been conducted, including functional testing?
  • At a high-level, is the code quality sufficient?
  • Are the base, milestone and labels correct?

@jclarkeSTFC jclarkeSTFC added this to the Release 6.16 milestone Feb 5, 2026
@jclarkeSTFC jclarkeSTFC added the Epic Used for issues and PRs that are managed under the ISIS Epic Workstream label Feb 5, 2026
@jclarkeSTFC jclarkeSTFC moved this to In review in Instrument View 2.0 Feb 5, 2026
@jclarkeSTFC jclarkeSTFC marked this pull request as ready for review February 5, 2026 14:33
@RichardWaiteSTFC RichardWaiteSTFC merged commit ecb712c into mantidproject:main Feb 9, 2026
10 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in Instrument View 2.0 Feb 9, 2026
@jclarkeSTFC jclarkeSTFC deleted the stop_accidental_combo_scrolling_iv branch February 9, 2026 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Epic Used for issues and PRs that are managed under the ISIS Epic Workstream

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants