Skip to content

Add IMAGINE instrument definition and update MaskBTP#40824

Merged
peterfpeterson merged 3 commits intomainfrom
imagine_maskbtp
Feb 9, 2026
Merged

Add IMAGINE instrument definition and update MaskBTP#40824
peterfpeterson merged 3 commits intomainfrom
imagine_maskbtp

Conversation

@jmborr
Copy link
Member

@jmborr jmborr commented Feb 4, 2026

Companion to #40825
EWM 14495

Description of work

Support for the IMAGINE instrument to the Mantid project by:

  1. Adding a new instrument definition file (IMAGINE_Definition_2025_10_01.xml)
  2. Updating the MaskBTP algorithm to support IMAGINE
  3. Adding unit tests for the IMAGINE instrument in MaskBTPTest.py

To test:

ws = LoadEmptyInstrument(InstrumentName="IMAGINE", OutputWorkspace="imagine")
masked_banks = MaskBTP(Workspace=ws, Bank="11-18")
assert len(masked_banks) == 8 * 512 * 512

Reviewer

Your comments will be used as part of the gatekeeper process. Comment clearly on what you have checked and tested during your review. Provide an audit trail for any changes requested.

As per the review guidelines:

  • Is the code of an acceptable quality? (Code standards/GUI standards)
  • Has a thorough functional test been performed? Do the changes handle unexpected input/situations?
  • Are appropriately scoped unit and/or system tests provided?
  • Do the release notes conform to the guidelines and describe the changes appropriately?
  • Has the relevant (user and developer) documentation been added/updated?
  • If the PR author isn’t in the mantid-developers or mantid-contributors teams, add a review comment rerun ci to authorize/rerun the CI

Gatekeeper

As per the gatekeeping guidelines:

  • Has a thorough first line review been conducted, including functional testing?
  • At a high-level, is the code quality sufficient?
  • Are the base, milestone and labels correct?

…figurations

Signed-off-by: Jose Borreguero <borreguero@gmail.com>

This comment was marked as resolved.

Signed-off-by: Jose Borreguero <borreguero@gmail.com>
Signed-off-by: Jose Borreguero <borreguero@gmail.com>
@jmborr

This comment was marked as resolved.

@coderabbitai

This comment was marked as resolved.

@coderabbitai

This comment was marked as resolved.

@jmborr jmborr requested a review from rosswhitfield February 4, 2026 22:30
@jmborr jmborr added Diffraction Issues and pull requests related to diffraction Framework Issues and pull requests related to components in the Framework and removed Framework Issues and pull requests related to components in the Framework labels Feb 5, 2026
@peterfpeterson peterfpeterson merged commit 17ca669 into main Feb 9, 2026
12 checks passed
@jmborr jmborr deleted the imagine_maskbtp branch February 9, 2026 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Diffraction Issues and pull requests related to diffraction

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants