fix: escape + in Base64 string regex pattern#1116
Open
vishwaksen-1 wants to merge 2 commits intomandiant:masterfrom
Open
fix: escape + in Base64 string regex pattern#1116vishwaksen-1 wants to merge 2 commits intomandiant:masterfrom
vishwaksen-1 wants to merge 2 commits intomandiant:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
williballenthin
approved these changes
Feb 11, 2026
mike-hunhoff
approved these changes
Feb 11, 2026
Collaborator
|
Thanks @vishwaksen-1 , unfortunately tests are failing: Please investigate and address accordingly. |
Author
|
Yes I'll go through that. |
Author
|
It was a mistake on my end, I was accidentally running liter on previous version rather than the one I edited and hence missed it 😅. I think it works now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the unescaped
+character in the Base64 alphabet regex pattern.Problem
The
+character in line 20 was not escaped in the regex pattern/ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/. This caused it to be interpreted as a regex quantifier (meaning "one or more of the preceding character") instead of a literal+character that is part of the Base64 alphabet.Solution
Escaped the
+character as\+to match it literally.Changed:
To:
Testing
python scripts/lint.pyon the modified fileCloses #1101