Propagate mousewheel event if ctrl key is pressed.#331
Open
andkorsh wants to merge 1 commit intomalihu:masterfrom
Open
Propagate mousewheel event if ctrl key is pressed.#331andkorsh wants to merge 1 commit intomalihu:masterfrom
andkorsh wants to merge 1 commit intomalihu:masterfrom
Conversation
…g feature). Issue malihu#319.
andkorsh
changed the title
|
Hi, any idea why your solution was not merged yet? Is there a better way of achieving the same result? Thanks for reply |
Author
|
@fdewannemaeker Hi! Actually I have no idea sorry :) I don't even know whether it still compatible with current version or not. BTW, finally I've modified the library about 10 times and now we are using this custom version for more than one year. It's really the best library for scrolling. |
|
would be better, if it's an option rather than the default behaviour |
|
Is there a better solution now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typical browser behaviour allow us to zoom the page in/out by mouse wheel with control key pressed. It would be better if this behaviour still the same (Issue #319).
My change have been made and tested with Windows PC in Chrome and IE. I thought about Macs and I tried to test it on OS X Yosemite but it has no zoom feature by mousewheel at all. I googled how it can be enabled and found the following topic http://forums.macrumors.com/threads/zoom-with-control-mouse-wheel.1411306/ But after enabling "Use scroll gesture with..." nothing has changed and I decided to leave it as it is. By the way, jQuery.mousewheel event has no property commandKey and it should be determined by keyCode :)