Skip to content

Closed #244#245

Open
kirillbuga wants to merge 1 commit intomalihu:masterfrom
kirillbuga:destroy-method-issue
Open

Closed #244#245
kirillbuga wants to merge 1 commit intomalihu:masterfrom
kirillbuga:destroy-method-issue

Conversation

@kirillbuga
Copy link

No description provided.

@kirillbuga
Copy link
Author

We have special jquery plugin which allows us to avoid iframe usage in case, when one app embeds another. This plugin takes the index.html page of inner app and append it to the current page. That's leads to overriding the initial mCustomScrollbar instance and refreshes the counter of already existed scrollbars on the page. In this case "destroy" method removes scrollbar from other views that marked with the same id as for current container. I've modified the destroy method in order to avoid such situation. I know that it's hard to understand my problem, but anyway, the fix contains tiny performance optimisation because jQuery don't need a whole page lookup (I've replaced global jquery call with "find" inside current container).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant