Open
Conversation
Author
|
We have special jquery plugin which allows us to avoid iframe usage in case, when one app embeds another. This plugin takes the index.html page of inner app and append it to the current page. That's leads to overriding the initial mCustomScrollbar instance and refreshes the counter of already existed scrollbars on the page. In this case "destroy" method removes scrollbar from other views that marked with the same id as for current container. I've modified the destroy method in order to avoid such situation. I know that it's hard to understand my problem, but anyway, the fix contains tiny performance optimisation because jQuery don't need a whole page lookup (I've replaced global jquery call with "find" inside current container). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.