fix: show stopped and failed containers in dashboard and API#7082
Open
JeremieCrinon wants to merge 1 commit intomailcow:stagingfrom
Open
fix: show stopped and failed containers in dashboard and API#7082JeremieCrinon wants to merge 1 commit intomailcow:stagingfrom
JeremieCrinon wants to merge 1 commit intomailcow:stagingfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution Guidelines
What does this PR include?
This PR fixes a bug where stopped / crashed containers were not displayed in the dashboard and API.
Short Description
The logic for displaying stopped container was already there. I just added in
data/Dockerfiles/dockerapi/main.pya query parameter (all) that is optional on the route/containers/jsonof dockerapi. That way, the behavior from before isn't changed except when explicitly asked for on the dockerapi call.When this parameter is true, all the containers, including stopped ones are returned and can be handled.
I then added in
data/web/inc/functions.docker.inc.php, in theinfocase, in the dockerapi call, theallparameter.The rest was already handled, as my tests confirmed.
I also edited the docker-compose.yml to change the dockerapi's version as required by the contribution guidelines.
Affected Containers
Did you run tests?
I did some manual tests.
What did you tested?
I tested the app and API with all containers running, and with a container stopped.
Here is a few screenshots :
The dashboard with a container stopped :
The dashboard with all containers running :
The API with a container stopped :
What were the final results? (Awaited, got)
When a container is stopped, it's shown in the dashboard and API with the correct status.