Add task for creating DMG installation image #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I like this disk image, and it has some advantages over zip:
|
Contributor
|
@jirutka I prefer minimalistic background: bigger MacVim icon leads to confusion which icon I should drag into Applications folder. So if it'll be blurred enough and/or be background of "drag action", it will be better, really. |
Contributor
Author
|
@eirnym Okay, I’ll wait for reaction from @douglasdrumond and then I’ll possibly redesing the background picture a bit. I don’t want to waste my time for the second time, just 3 years later. ;) |
Contributor
|
@jirutka I hope there's no problems with licences. |
Contributor
Author
Contributor
|
Tool you used is under MIT licence. |
Contributor
Author
|
Ah, that one. MIT is very permissive license, so I hope that it’s not a problem. However, I’m not a lawyer. |
douglasdrumond
added a commit
that referenced
this pull request
Aug 23, 2015
Add task for creating DMG installation image
Contributor
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was asked by @eirnym to send PR b4winckler/macvim#26 (that I’ve created 3 years ago) to this repository. I rewrote it to a make task, changed MacVim logo in a background image to your new shiny logo and redesigned the background a bit.