Refactor userland calls to limit usage of confusing Zend APIs#55
Open
Girgias wants to merge 1 commit intom6w6:masterfrom
Open
Refactor userland calls to limit usage of confusing Zend APIs#55Girgias wants to merge 1 commit intom6w6:masterfrom
Girgias wants to merge 1 commit intom6w6:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The motivation is that long term I want to get rid of the
zend_fcall_info_*()APIs in php-src.Ideally I would convert
php_pq_callback_tto only store an FCC but that API only exists as of PHP 8.3 as that's when it started dealing with closures properly. The other annoyance is handling trampolines, for which I might need to improve handling on the php-src side.